Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIDER: Colon after pill is missing #11563

Closed
aaronraimist opened this issue Nov 30, 2019 · 6 comments · Fixed by matrix-org/matrix-react-sdk#3886
Closed

CIDER: Colon after pill is missing #11563

aaronraimist opened this issue Nov 30, 2019 · 6 comments · Fixed by matrix-org/matrix-react-sdk#3886
Assignees
@t3chguy
Labels
A-Composer

Comments

@aaronraimist
Copy link
Collaborator

aaronraimist commented Nov 30, 2019 •
edited
Loading

Old composer automatically inserted a : after the pill when you click to ping someone. I keep manually inserting it but it would be really nice to get back.
@t3chguy
Copy link
Member

t3chguy commented Nov 30, 2019

Looks like a regression: #10680

@aaronraimist
Copy link
Collaborator Author

and actually I just realized this is Safari specific. It appears to work in Firefox.

@aaronraimist
Copy link
Collaborator Author

Hmm toggling the new composer off and on gives me colons back? Maybe just some borked something?

@aaronraimist
Copy link
Collaborator Author

Closing for now

@aaronraimist
Copy link
Collaborator Author

Nope this is still an issue.

It works correctly when there is nothing in the composer but often I write out a message and then realize I need to mention the person so I put the cursor at the beginning of the composer and click to ping. The composer I guess is trying to be smart and not put a colon since I've written stuff but since my cursor is at the start, I actually do want a colon.

@aaronraimist aaronraimist reopened this Jan 16, 2020
@t3chguy t3chguy self-assigned this Jan 21, 2020
@t3chguy
Copy link
Member

t3chguy commented Jan 21, 2020

This is limited only to click to ping

@t3chguy t3chguy mentioned this issue Jan 21, 2020
Merged
@MadLittleMods MadLittleMods mentioned this issue Nov 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Composer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix click-to-ping not inserting colon if composer non-empty matrix-org/matrix-react-sdk
2 participants
@t3chguy @aaronraimist