Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not insert trailing colon after mention/pill if cursor is in the middle of a message #15794

Closed
MadLittleMods opened this issue Nov 23, 2020 · 0 comments · Fixed by matrix-org/matrix-react-sdk#5830
Labels
A-Composer A-Pills T-Enhancement Z-Papercuts Visible. Impactful. Predictable to action.

Comments

@MadLittleMods
Copy link
Contributor

MadLittleMods commented Nov 23, 2020

Is your suggestion related to a problem? Please describe.

When mentioning a user by clicking their name to autofill the mention or using the user typeahead, there is always a trailing colon(:) after the mention/pill which doesn't fit right in the middle of a sentence.

Describe the solution you'd like

Do not insert trailing colon after mention/pill if your cursor is in the middle of a message.

The trailing colon seems fine for the start of a message or new line but doesn't seem correct to use it in the middle of a sentence/message.

Describe alternatives you've considered

Alternatives could be not inserting a colon at all.

For reference on Gitter, we just insert the @mention plus a space after.

Additional context

I'm making this issue while thinking about https://gitlab.com/gitterHQ/webapp/-/issues/2654 but I am not suggesting this is a fix for that issue.

Related issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer A-Pills T-Enhancement Z-Papercuts Visible. Impactful. Predictable to action.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants