This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix inserting trailing colon after mention/pill #5830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
This removes the handling of trailing chars from createMentionParts as we need to determine whether or not to insert the trailing char differently in different situations Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
|
Wonder if it'd be worth looking into element-hq/element-web#4883 at the same time as that will likely overhaul this area |
|
Hmm, maybe later. First, I'd fix the current behaviour and then I'd think about that and also #16682 |
|
Well element-hq/element-web#16682 is to abolish this behaviour entirely which has pretty much been all but rejected by M |
|
@bwindels, perhaps you have thoughts on this with your composer hat on? |
turt2live
approved these changes
Apr 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15794
This removes the handling of trailing characters from
createMentionParts()as we need to determine whether or not to insert the trailing character differently in different situationsI have to admit that my understanding of how the composer works is highly limited but this seems to work and make sense 😅