-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider an option to send a screenshot with rageshakes #12227
Labels
A-Feedback-Reporting
Reporting process for bugs, debug logs (rageshakes), suggestions
O-Occasional
Affects or can be seen by some users regularly or most users rarely
T-Enhancement
X-Needs-Design
Comments
aaronraimist
added
the
A-Feedback-Reporting
Reporting process for bugs, debug logs (rageshakes), suggestions
label
Feb 4, 2020
likely pair this with #9615 |
For reference, in the anonymized screenshot demo, for the "Submit debug logs" modal mockup, I used Code to create the screenshot mockup// Import html-to-image
// Open the "Submit debug logs" modal (rageshake)
(async () => {
document.querySelector('.mx_RoomView_MessageList').style.removeProperty('height');
const dataUrl = await htmlToImage.toPng(document.querySelector('body'), {
filter: (node) => {
// Hide the noscript warning that Element has
const isNoScript = node.tagName && node.tagName.toLowerCase() === 'noscript';
// Hide the rageshake modal itself so we can screenshot what's under it
const isModal = node.classList && node.classList.contains('mx_Dialog_wrapper');
return !(isNoScript || isModal);
}
});
var img = new Image();
img.src = dataUrl;
img.style.maxWidth = '500px';
img.style.maxHeight = '300px';
img.style.objectFit = 'contain';
img.style.border = '1px solid #000';
img.style.filter = 'none';
document.querySelector('.mx_Dialog_content').appendChild(img);
})(); |
SimonBrandner
added
X-Needs-Design
T-Enhancement
O-Occasional
Affects or can be seen by some users regularly or most users rarely
labels
May 7, 2022
t3chguy
pushed a commit
that referenced
this issue
Oct 17, 2024
* Add `Thread Activity centre` labs flag * Rename translation string * WIP Thread Activity Centre * Update supportedLevels * css lint * i18n lint * Fix labs subsection test * Update Threads Activity Centre label * Rename Thread Activity Centre to Threads Activity Centre * Use compound `MenuItem` instead of custom button * Color thread icon when hovered * Make the pop-up scrollable and add a max height * Remove Math.random in key * Remove unused class * Change add comments on `mx_ThreadsActivityRows` and `mx_ThreadsActivityRow` * Make threads activity centre labs flag split out unread counts Just shows notif & unread counts for main thread if the TAC is enabled. * Fix tests * Simpler fix * Open thread panel when thread clicke in Threads Activity Centre Hopefully this is a sensible enough way. The panel will stay open of course (ie. if you go to a different room & come back), but that's the nature of the right panel. * Dynamic state of room * Add doc * Use the StatelessNotificationBadge component in ThreadsActivityCentre and re-use the existing NotificationLevel * Remove unused style * Add room sorting * Fix `ThreadsActivityRow` props doc * Pass in & cache the status of the TAC labs flag * Pass includeThreads as setting to doesRoomHaveUnreadMessages too * Fix tests * Add analytics to the TAC (#12179) * Update TAC label (#12186) * Add `IndicatorIcon` to the TAC button (#12182) Add `IndicatorIcon` to the TAC button * Threads don't have activity if the room is muted This makes it match the computation in determineUnreadState. Ideally this logic should all be in one place. * Re-use doesRoomHaveUnreadThreads for useRoomThreadNotifications This incorporates the logic of not showing unread dots if the room is muted * Add TAC description in labs (#12197) * Fox position & size of dot on the tac button IndicatorIcon doesn't like having the size of its icon adjusted and we probably shouldn't do it anyway: better to specify to the component what size we want it. * TAC: Utils tests (#12200) * Add tests for `doesRoomHaveUnreadThreads` * Add tests for `getThreadNotificationLevel` * Add test for the ThreadsActivityCentre component * Add snapshot test * Fix narrow hover background on TAC button Make the button 32x32 (and the inner icon 24x24) * Add caption for empty TAC * s/tac/threads_activity_centre/ * Fix i18n & add tests * Add playwright tests for the TAC (#12227) * Fox comments --------- Co-authored-by: David Baker <dbkr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Feedback-Reporting
Reporting process for bugs, debug logs (rageshakes), suggestions
O-Occasional
Affects or can be seen by some users regularly or most users rarely
T-Enhancement
X-Needs-Design
Like the mobile apps
The text was updated successfully, but these errors were encountered: