Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control+home/end not working as expected in the editor #12438

Closed
jryans opened this issue Feb 20, 2020 · 3 comments · Fixed by matrix-org/matrix-react-sdk#4108
Closed

Control+home/end not working as expected in the editor #12438

jryans opened this issue Feb 20, 2020 · 3 comments · Fixed by matrix-org/matrix-react-sdk#4108

Comments

@jryans
Copy link
Collaborator

jryans commented Feb 20, 2020

I get bitten on a daily basis by control+home/control+end not working as expected in the editor (i.e. scrolling instead of jumping to start/end of editor message). I'm a screen reader user (and thus keyboard only user), and while this isn't screen reader specific, I wonder if it impacts keyboard only users more; i.e. perhaps most users just use the mouse to jump to the start/end of multi-line messages.

Originally posted by @jcsteh in #4736 (comment)

@bwindels
Copy link
Contributor

Can repro indeed, should be easy to do in BasicMessageComposer._onKeyDown

@jryans jryans self-assigned this Feb 21, 2020
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Feb 21, 2020
This adds Ctrl/Command+Home/End shortcuts for jumping to the start and end of
the composer contents.

Fixes element-hq/element-web#12438
jryans added a commit that referenced this issue Feb 21, 2020
This documents shortcuts for jumping to the start / end of the composer
contents.

Part of #12438
Depends on matrix-org/matrix-react-sdk#4108
@aaronraimist aaronraimist added the A-Shortcuts Keyboard shortcuts label Feb 22, 2020
@jcsteh
Copy link

jcsteh commented Feb 27, 2020

This is great - thanks! - except for one thing: shift+control+home and shift+control+end (select to start/end) now get treated as control+home/control+end. I guess the code doesn't check for the shift key? Anyway, that's a bit problematic if, for example, you type a message, start editing it, then realise you wrote a lot of garbage after a certain point (not enough coffee or something like that) and want to delete it.

@jryans
Copy link
Collaborator Author

jryans commented Feb 27, 2020

Aha, thanks for pointing that out @jcsteh! I have opened #12549 to fix.

@jryans jryans added A11y and removed I18n labels Mar 5, 2021
t3chguy pushed a commit that referenced this issue Oct 17, 2024
* Move the TAC to above the button

This isn't what the designs say, but there is a (bug/feature)* in
radix where it will turn a mouseup event within the menu into a
click so that it activates the menu option that's under your cursor
when you lift the button, even if you pressed the button down on
a different item. Unfortunately it forgot to check that the mouse
down happened in the menu, so if the menu appears under the cursor,
the cursor, it will immediately select whatever option appeared under
the cursor.

I think the simplest solution here is to just move the menu above the
TAC button. This also makes it consistent† with quick settings.

*delete as applicable
†Not actually consistent because it fades in a different way

* Update snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants