Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing does not instantly update the shown message #17702

Closed
HarHarLinks opened this issue Jun 19, 2021 · 5 comments
Closed

Editing does not instantly update the shown message #17702

HarHarLinks opened this issue Jun 19, 2021 · 5 comments
Assignees
@turt2live
Labels
A-Message-Editing P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression

Comments

@HarHarLinks
Copy link
Contributor

HarHarLinks commented Jun 19, 2021 •
edited
Loading

Description

edit is only displayed after switching rooms back and forth

image

image

Steps to reproduce

  • post msg
  • press arrow up to edit
  • edit
  • enter
  • see it say (edited) and view the edit history. however the edit is only displayed after switching rooms back and forth

Describe how what happens differs from what you expected.

Logs being sent: no

Version information

  • Platform: desktop

For the desktop app:

  • OS: Arch
  • Version: aur/element-desktop-nightly-bin 2021061901-1
@HarHarLinks
Copy link
Contributor Author

This also applies to edits by other room members.

@t3chguy t3chguy added S-Major Severely degrades major functionality or product features, with no satisfactory workaround X-Regression labels Jun 19, 2021
@t3chguy
Copy link
Member

t3chguy commented Jun 19, 2021

Regressed by matrix-org/matrix-react-sdk#6196 / matrix-org/matrix-js-sdk#1738

@turt2live
Copy link
Member

immediate issue fixed by matrix-org/matrix-react-sdk#6196 - leaving open for further investigation.

@HarHarLinks HarHarLinks mentioned this issue Jun 20, 2021
Closed
@jryans
Copy link
Collaborator

jryans commented Jun 21, 2021

Removing release blocker since the regressing change was reverted.

@turt2live turt2live mentioned this issue Jul 22, 2021
Open
@turt2live
Copy link
Member

Closing this issue as it's not actually an issue in current releases, but if we ever do re-launch the problematic feature then it'll become an issue again. I've tracked this awkward state here: #18193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Message-Editing P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jryans @turt2live @t3chguy @HarHarLinks