Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functions to assist in immutability of Event objects #1738

Merged
merged 7 commits into from
Jun 18, 2021
Merged

Add functions to assist in immutability of Event objects #1738

merged 7 commits into from
Jun 18, 2021

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Jun 15, 2021 •
edited
Loading

@turt2live turt2live mentioned this pull request Jun 15, 2021
Merged
@turt2live turt2live requested a review from a team June 15, 2021 20:36
@turt2live turt2live marked this pull request as ready for review June 15, 2021 20:36
jryans
jryans approved these changes Jun 17, 2021
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but please consider tweaking the name.

spec/unit/utils.spec.ts Outdated Show resolved Hide resolved
src/models/event.js Outdated Show resolved Hide resolved
src/models/event.js Outdated Show resolved Hide resolved
src/models/event.js Outdated Show resolved Hide resolved
@turt2live
Copy link
Member Author

@jryans I've reworded the function docs a bit - can I get a second look?

@turt2live turt2live requested a review from jryans June 17, 2021 20:25
jryans
jryans approved these changes Jun 18, 2021
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks! 😄

src/models/event.js Outdated Show resolved Hide resolved
@turt2live turt2live mentioned this pull request Jun 18, 2021
Open
@turt2live turt2live merged commit fedd9a9 into develop Jun 18, 2021
@turt2live turt2live deleted the travis/event-fixes branch June 18, 2021 17:23
This was referenced Jun 19, 2021
Closed
Closed
@HarHarLinks HarHarLinks mentioned this pull request Jun 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
Sponsored
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turt2live @jryans