Images have excess padding under them

[turt2live]

develop/nightly

[SimonBrandner]

I don't think I can repro

[turt2live]

It appears to be wide-ish images that cause it. The blurhash takes the appropriate area, but the image does not.

[SimonBrandner]

Still nothing with 1152x648

[turt2live]

@SimonBrandner what version of Nightly are you using? I'm still seeing this on 0.0.1-nightly.2021080101 with a 1712x480 image (for example).

[SimonBrandner]

Size: 1712x480
Version: 2021080101

Someone else should probably try because I am probably doing something wrong

[turt2live]

figured it out: it's the thumbnail dimensions.

Source image is 1712x480 but the thumbnail is listed at 800x224 (due to the ?width=800&height=600&method=scale params on the thumbnail request). This causes the gap because the image height and the thumbnail height are now incorrect, largely due to us not scaling images in the timeline like we used to.

Previously, we'd over-extend the image (or use the thumbnail dimensions) which would cause a slightly blurry thumbnail or an accurate tile size. My guess is with the blurhash and message bubbles work overlapping we've ended up with a regression in thumbnail handling, particularly seeing as how various CSS attributes for images have changed in recent weeks and the blurhash takes the "correct" amount of space.

[t3chguy]

So when the blurhashes were too big they were actually the right size but the thumbs had shrunk :P