Favourites created in Spaces show up in Home

[novocaine]

Steps to reproduce

1. Pin some rooms in a space as favourites
2. Select the "Home" space
3. See the rooms still visible as favourites

What happened?

The rooms are still visible in the favourites panel.

What did you expect?

Home contains rooms that aren't in a space, so I'd expect to not see favourites that are in a space.

I would expect this behaviour if I had "Show all rooms in Home" enabled, but I don't.

Operating system

OS X

Browser information

Chrome

URL for webapp

app.element.io

Have you submitted a rageshake?

No

[SimonBrandner]

This is intentional design, afaik. Home should be your place with high priority stuff -> all favourites are there

[novocaine]

This is intentional design, afaik. Home should be your place with high priority stuff -> all favourites are there

Indeed it's intentional - but design agrees that this is indeed confusing

[t3chguy]

Spec m.tag m.favourite has no concept of Spaces

[novocaine]

One possible way to fix this is to change the UI so that it's more obvious that favourites aren't part of the Spaces heirarchy - at the moment, it seems like they are, because they sit in a panel with other objects that are (channels and people).

So removing X-Spec-Changes as it ain't necessarily so, whilst noting that it would require a spec change if we actually did want to make favourites per-space.

[daniellekirkwood]

As this is working "as expected" I'm going to change this from an Enhancement to a Defect.

I'll also be tagging with an IA tag so we can take a look at similar feedback and how we want to address the confusion of Favourites by Space/Global items in the layout.

[TuringTux]

I personally would really like to have per-space favorites, they would help me quite a bit to get my stuff sorted.

However, I understand that there is probably quite some work attached, so I definitely don't expect anything, just wanted to chime in with my two cents.

Thank you for your development work, I really like Element a lot :)

[jerrykan]

I find it weird/intuitive that that favourites are treated differently to other rooms in the Home view.

If I have "Show all rooms" unchecked for the Home view, then I would expect the only favourites shown in the Home view would be those rooms that are not in a Space. Similar to how the only favourites shown in a Space are rooms belonging to that space.

[dos1]

This applies also to People. I have sorted my rooms and people across spaces with sole intention to not have them show up in Home, where I expected to see only rooms/people that don't belong to any space. Afterwards it took me some time to realize that "Show all rooms" switch even worked at all, because it wasn't influencing my list of rooms in any visible way when it was scrolled to the top (so with only Favorites and People in view).

[FlorianFranzen]

I think the concise way to do this would exclude favorites that part of a space, because spaces exclude favorites that are not in their space too.

I would then change "Show all rooms in Home" to "Show rooms in Space under Home" with "None", "Favorites" and "All" as an option. Then it is fully configurable.

[t3chguy]

I think the concise way to do this would exclude favorites that part of a space, because spaces exclude favorites that are not in their space too.

This is the plan, as part of an ongoing project

[frandavid100]

This is amazing. Just a request: would it be possible to make these draggable, like other spaces are?

[t3chguy]

It'd be difficult because the spec for ordering only considers real spaces, and most clients won't have identical meta-spaces

matrix-org/matrix-spec-proposals#3230 is the relevant MSC

We could have an element-specific extension of it, but then a re-order from a non-Element client may have unexpected effects for Element clients. I suggest opening a new issue for it regardless.

[SimonBrandner]

I guess we could do some localStorage magic 🤔