Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop doesn't recognize custom room list background image whereas nightly does #18705

Closed
turt2live opened this issue Aug 24, 2021 · 2 comments · Fixed by matrix-org/matrix-react-sdk#6663
Closed

Develop doesn't recognize custom room list background image whereas nightly does #18705

turt2live opened this issue Aug 24, 2021 · 2 comments · Fixed by matrix-org/matrix-react-sdk#6663
Assignees
@turt2live
Labels
T-Defect X-Regression X-Release-Blocker

Comments

@turt2live
Copy link
Member

Steps to reproduce

  1. Be on develop.element.io
  2. Have a custom room list background image
  3. Note that the room list doesn't care
  4. Note that nightly for the same account does respect it

What happened?

My custom room list image was not applied

What did you expect?

For it to be applied

Operating system

Windows 10

Browser information

Chrome

URL for webapp

develop.element.io

Have you submitted a rageshake?

No
@turt2live
Copy link
Member Author

Develop:

Element version: 0e82b884e84e-react-32343f338217-js-62c93f54ccbd
Olm version: 3.2.3

Nightly:

Element Nightly version: 0.0.1-nightly.2021082301
Olm version: 3.2.3

Marking release blocker due to a11y impact.

@turt2live
Copy link
Member Author

Regressed by matrix-org/matrix-react-sdk#6659

@turt2live turt2live self-assigned this Aug 24, 2021
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 24, 2021
@turt2live
Honour user-selected background image from settings
a0dc5d2 
Fixes element-hq/element-web#18705

This is provided as an easter egg, but more importantly as an a11y workaround.
@turt2live turt2live mentioned this issue Aug 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Honour user-selected background image from settings matrix-org/matrix-react-sdk
1 participant
@turt2live