Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Location Sharing if map_style_url is not provided #21082

Open
SPiRiT369 opened this issue Feb 14, 2022 · 7 comments
Open

Disable Location Sharing if map_style_url is not provided #21082

SPiRiT369 opened this issue Feb 14, 2022 · 7 comments
Assignees
Labels
A-Location-Sharing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Needs-Product More input needed from the Product team Z-Labs

Comments

@SPiRiT369
Copy link
Contributor

SPiRiT369 commented Feb 14, 2022

Steps to reproduce

  • Remove "map_style_url" from config.json or set it to blank.
  • Try to share Location.
  • You'll get an error message: "Failed to load map"

image

Outcome

What did you expect?

Since map_style_url is not provided - the option to share Location should be hidden/disabled.
Alternatively, admins should be able to hide it within the "settingDefaults" section (e.g. set "UIFeature.shareLocation" to false).
Note that this feature requires registering for getting a key. I'm not sure all HS admins would do that, also some HS might want to disable it because of privacy concerns.

What happened instead?

Error message is shown.

Application version

Element Web 1.10.2

@SimonBrandner SimonBrandner added A-Location-Sharing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist labels Feb 14, 2022
@dbkr dbkr added T-Enhancement X-Needs-Product More input needed from the Product team and removed T-Defect labels Feb 14, 2022
@dbkr
Copy link
Member

dbkr commented Feb 14, 2022

Would also need to decide how to render shared locations in the timeline

@SPiRiT369 SPiRiT369 changed the title Disable Location sharing if map_style_url is not provided Disable Location Sharing if map_style_url is not provided Feb 14, 2022
@Half-Shot
Copy link
Member

As a fallback, it might be okay to have the sender include a thumbnail and url pointing to a place where they can look at the map out-of-band?

@jaller94
Copy link
Contributor

ChristianP shared a location:
[49.31008° N, 123.07991° W](geo:49.31008,-123.07991)

@markiceman
Copy link

I need the ability to disable location sharing ...

@jakewb-b jakewb-b self-assigned this Mar 4, 2022
@jakewb-b
Copy link

jakewb-b commented Mar 4, 2022

I'm not convinced that this:

Since map_style_url is not provided the option to share Location should be hidden/disabled.

Is the right fix since
a) It is possible to share your location even if tiles are not being loaded on your own client for whatever reason, and other users will still see the location correctly.
b) Even if you disable your own ability to share locations, you may still receive locations shared by other users, and the tiles will not load there.

So hiding/disabling the option to share when tiles are not available introduces a potentially frustrating limitation while also failing to fully resolve the issue.

For now, we're also adding a more useful error message in cases where tiles cannot be loaded for whatever reason.

We're also intending to offer the ability to disable viewing locations at all - for users/admins who have privacy concerns about it or don't wish to set up their own tileserver or use the Element-provided one.

@SPiRiT369
Copy link
Contributor Author

I understand that sharing users' location might be helpful for some.
However, business users, or myself, having a non-federated server with zero need to share locations, will appreciate the (basic) ability to disable this feature for providing a more clean interface to the users.
I can (and I do) disable widgets, voip, integrations etc' - so why not to give homeserver admins the choise&control to customize their server?
As a developer, you should take in mind that different users have different use-cases.
Just to make it clear: This is a simple request, just to hide that "Share Location" icon. If there are other challenges (like other users sharing location using different client) - then it's a different issue and not relevant to my request. I just want to hide it.

@hex-m
Copy link

hex-m commented Apr 19, 2022

The desktop build has no "share location"-button, so the option to hide it should already be implemented somewhere.

This should probably be split into two issues:

  1. fallback for location rendering without external service (without map_style_url)
  2. setting to hide the "share location" button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Location-Sharing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Needs-Product More input needed from the Product team Z-Labs
Projects
None yet
Development

No branches or pull requests

8 participants