-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Location Sharing if map_style_url is not provided #21082
Comments
Would also need to decide how to render shared locations in the timeline |
As a fallback, it might be okay to have the sender include a thumbnail and url pointing to a place where they can look at the map out-of-band? |
|
I need the ability to disable location sharing ... |
I'm not convinced that this:
Is the right fix since So hiding/disabling the option to share when tiles are not available introduces a potentially frustrating limitation while also failing to fully resolve the issue. For now, we're also adding a more useful error message in cases where tiles cannot be loaded for whatever reason. We're also intending to offer the ability to disable viewing locations at all - for users/admins who have privacy concerns about it or don't wish to set up their own tileserver or use the Element-provided one. |
I understand that sharing users' location might be helpful for some. |
The desktop build has no "share location"-button, so the option to hide it should already be implemented somewhere. This should probably be split into two issues:
|
Steps to reproduce
Outcome
What did you expect?
Since map_style_url is not provided - the option to share Location should be hidden/disabled.
Alternatively, admins should be able to hide it within the "settingDefaults" section (e.g. set "UIFeature.shareLocation" to false).
Note that this feature requires registering for getting a key. I'm not sure all HS admins would do that, also some HS might want to disable it because of privacy concerns.
What happened instead?
Error message is shown.
Application version
Element Web 1.10.2
The text was updated successfully, but these errors were encountered: