Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maximised widgets prevent people from joining a room when peeking into the room #21542

Closed
thibaultamartin opened this issue Mar 24, 2022 · 4 comments · Fixed by matrix-org/matrix-react-sdk#8180
Closed

Maximised widgets prevent people from joining a room when peeking into the room #21542

thibaultamartin opened this issue Mar 24, 2022 · 4 comments · Fixed by matrix-org/matrix-react-sdk#8180
Assignees
@jryans
Labels
A-Room-View O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Maximised-Widgets

Comments

@thibaultamartin
Copy link
Contributor

Steps to reproduce

  1. Create a room
  2. Add a widget (e.g. YT video), maximise it, set layout for everyone
  3. Make the room public, enable guest access, make history readable by everyone, and join at least a matrix.org user in the room
  4. Send a matrix.to link to the room to someone else

Outcome

What did you expect?

I expect the person to be told they're seeing a preview, and asked if they want to join the room to participate in the conversation.

What happened instead?

The person sees the maximised widget, and they are told in the right panel (timeline) they are not allowed to participate in the conversation. They don't know they are only previewing the room, and they have no way to join the room.

Operating system

macOS 12.2.1 (Monterey)

Application version

Element Nightly version: 2022032301

How did you install the app?

https://element.io/get-started#nightly

Homeserver

ergaster.org on Synapse 1.55.0, openforumeurope.org on Synapse 1.54.0, matrix.org

Will you send logs?

No
@t3chguy
Copy link
Member

t3chguy commented Mar 24, 2022

and they have no way to join the room.

Element Web/Desktop don't allow guests to join rooms anyway, they're forced to register.

@thibaultamartin
Copy link
Contributor Author

When sharing a matrix.to link to a someone who already has a registered account, their Element only shows the preview. So registered people cannot join the room from Element.

Here is a screenshot taken from Element Desktop, with someone logged in with a matrix.org account and who tried to join a room with maximised widgets.

Screenshot 2022-03-23 at 16 07 47

They can't post messages in the room, but they don't know they are only previewing the room and have not way to join

@t3chguy t3chguy changed the title Maximised widgets prevent people from joining a room when guest mode is enabled Maximised widgets prevent people from joining a room when peeking into the room Mar 24, 2022
@germain-gg germain-gg added S-Minor Impairs non-critical functionality or suitable workarounds exist A-Room-View O-Occasional Affects or can be seen by some users regularly or most users rarely Z-Maximised-Widgets labels Mar 24, 2022
@t3chguy
Copy link
Member

t3chguy commented Mar 24, 2022

Updated the title to better explain how guests fit into this.

@jryans
Copy link
Collaborator

jryans commented Mar 24, 2022

Planning to take a look at this next week.

@jryans jryans self-assigned this Mar 24, 2022
@jryans jryans mentioned this issue Mar 28, 2022
Merged
kegsay added a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 14, 2022
@kegsay
Merge tag 'v3.42.3' into kegan/sync-v3
4efc389 
* Release threads as a beta feature ([\#8081](#8081)). Fixes element-hq/element-web#21351.
* More video rooms design updates ([\#8222](#8222)).
* Update video rooms to new design specs ([\#8207](#8207)). Fixes element-hq/element-web#21515, element-hq/element-web#21516 element-hq/element-web#21519 and element-hq/element-web#21526.
* Live Location Sharing - left panel warning with error ([\#8201](#8201)).
* Live location sharing - Stop publishing location to beacons with consecutive errors ([\#8194](#8194)).
* Live location sharing: allow retry when stop sharing fails ([\#8193](#8193)).
* Allow voice messages to be scrubbed in the timeline ([\#8079](#8079)). Fixes element-hq/element-web#18713.
* Live location sharing - stop sharing to beacons in rooms you left ([\#8187](#8187)).
* Allow sending and thumbnailing AVIF images ([\#8172](#8172)).
* Live location sharing - handle geolocation errors ([\#8179](#8179)).
* Show voice room participants when not connected ([\#8136](#8136)). Fixes element-hq/element-web#21513.
* Add margins between labs sections ([\#8169](#8169)).
* Live location sharing - send geolocation beacon events - happy path ([\#8127](#8127)).
* Add support for Animated (A)PNG ([\#8158](#8158)). Fixes element-hq/element-web#12967.
* Don't form continuations from thread roots ([\#8166](#8166)). Fixes element-hq/element-web#20908.
* Improve handling of animated GIF and WEBP images ([\#8153](#8153)). Fixes element-hq/element-web#16193 and element-hq/element-web#6684.
* Wire up file preview for video files ([\#8140](#8140)). Fixes element-hq/element-web#21539.
* When showing thread, always auto-focus its composer ([\#8115](#8115)). Fixes element-hq/element-web#21438.
* Live location sharing - refresh beacon expiry in room ([\#8116](#8116)).
* Use styled mxids in member list v2 ([\#8110](#8110)). Fixes element-hq/element-web#14825. Contributed by @SimonBrandner.
* Delete groups (legacy communities system) ([\#8027](#8027)). Fixes element-hq/element-web#17532.
* Add a prototype of voice rooms in labs ([\#8084](#8084)). Fixes element-hq/element-web#3546.
* Fix editing `<ol>` tags with a non-1 start attribute ([\#8211](#8211)). Fixes element-hq/element-web#21625.
* Fix URL previews being enabled when room first created ([\#8227](#8227)). Fixes element-hq/element-web#21659.
* Don't use m.call for Jitsi video rooms ([\#8223](#8223)).
* Scale emoji with size of surrounding text ([\#8224](#8224)).
* Make "Jump to date" translatable ([\#8218](#8218)).
* Normalize call buttons ([\#8129](#8129)). Fixes element-hq/element-web#21493. Contributed by @luixxiul.
* Show room preview bar with maximised widgets ([\#8180](#8180)). Fixes element-hq/element-web#21542.
* Update more strings to not wrongly mention room when it is/could be a space ([\#7722](#7722)). Fixes element-hq/element-web#20243 and element-hq/element-web#20910.
* Fix issue with redacting via edit composer flow causing stuck editStates ([\#8184](#8184)).
* Fix some image/video scroll jumps ([\#8182](#8182)).
* Fix "react error on share dialog" ([\#8170](#8170)). Contributed by @yaya-usman.
* Fix disambiguated profile in threads in bubble layout ([\#8168](#8168)). Fixes element-hq/element-web#21570. Contributed by @SimonBrandner.
* Responsive BetaCard on Labs ([\#8154](#8154)). Fixes element-hq/element-web#21554. Contributed by @luixxiul.
* Display button as inline in room directory dialog ([\#8164](#8164)). Fixes element-hq/element-web#21567. Contributed by @luixxiul.
* Null guard TimelinePanel unmount edge ([\#8171](#8171)).
* Fix beta pill label breaking ([\#8162](#8162)). Fixes element-hq/element-web#21566. Contributed by @luixxiul.
* Strip relations when forwarding ([\#7929](#7929)). Fixes element-hq/element-web#19769, element-hq/element-web#18067 element-hq/element-web#21015 and element-hq/element-web#10924.
* Don't try (and fail) to show replies for redacted events ([\#8141](#8141)). Fixes element-hq/element-web#21435.
* Fix 3pid member info for space member list ([\#8128](#8128)). Fixes element-hq/element-web#21534.
* Set max-width to user context menu ([\#8089](#8089)). Fixes element-hq/element-web#21486. Contributed by @luixxiul.
* Fix issue with falsey hrefs being sent in events ([\#8113](#8113)). Fixes element-hq/element-web#21417.
* Make video sizing consistent with images ([\#8102](#8102)). Fixes element-hq/element-web#20072.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Room-View O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Maximised-Widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show room preview bar with maximised widgets matrix-org/matrix-react-sdk
4 participants
@jryans @germain-gg @thibaultamartin @t3chguy