Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use strictNullChecks in matrix-react-sdk #21967

Closed
54 tasks done
Tracked by #23542
novocaine opened this issue Apr 28, 2022 · 3 comments · Fixed by matrix-org/matrix-react-sdk#11194
Closed
54 tasks done
Tracked by #23542

Use strictNullChecks in matrix-react-sdk #21967

novocaine opened this issue Apr 28, 2022 · 3 comments · Fixed by matrix-org/matrix-react-sdk#11194
Assignees
@t3chguy
Labels
A-Developer-Experience A-Testing Testing, code coverage, etc. T-Enhancement

Comments

@novocaine
Copy link
Contributor

novocaine commented Apr 28, 2022 •
edited by t3chguy
Loading

Your use case

https://www.typescriptlang.org/tsconfig#strictNullChecks

This will reduce the number of runtime errors caused by unexpected null and undefined values by disallowing them as a value unless explicitly permitted.

Related: matrix-org/matrix-js-sdk#2112

Tasks
Beta Give feedback
  1. Apply strictNullChecks to src/voice-broadcast/* vector-im/element-web#24659
    A-Developer-Experience A-Testing T-Enhancement
    weeman1337
  2. Apply strictNullChecks to src/settings/* vector-im/element-web#24658
    A-Developer-Experience A-Testing T-Enhancement
    t3chguy
  3. Apply strictNullChecks to src/editor/* vector-im/element-web#24657
    A-Developer-Experience A-Testing T-Enhancement
    florianduros
  4. Apply strictNullChecks to src/components/views/room_settings/* vector-im/element-web#24656
    A-Developer-Experience A-Testing T-Enhancement
    t3chguy
  5. Apply strictNullChecks to src/components/views/location/* vector-im/element-web#24655
    A-Developer-Experience A-Testing T-Enhancement
    kerryarchibald
  6. Apply strictNullChecks to src/components/views/emojipicker/* vector-im/element-web#24654
    A-Developer-Experience A-Testing T-Enhancement
    t3chguy
  7. Apply strictNullChecks to src/components/views/beacon/* vector-im/element-web#24653
    A-Developer-Experience A-Testing T-Enhancement
    kerryarchibald
  8. Apply strictNullChecks to src/components/views/avatars/* vector-im/element-web#24652
    A-Developer-Experience A-Testing T-Enhancement
    t3chguy
  9. Apply strictNullChecks to src/components/views/auth/* vector-im/element-web#24651
    A-Developer-Experience A-Testing T-Enhancement
    t3chguy
  10. Apply strictNullChecks to src/components/views/audio_messages/* vector-im/element-web#24650
    A-Developer-Experience A-Testing T-Enhancement
    weeman1337
  11. Apply strictNullChecks to src/async-components/* vector-im/element-web#24649
    A-Developer-Experience A-Testing T-Enhancement
    t3chguy
  12. Apply strictNullChecks to src/utils/beacon/* vector-im/element-web#24756
    A-Developer-Experience A-Testing T-Enhancement
    kerryarchibald
  13. Apply strictNullChecks to src/stores/widgets/* vector-im/element-web#24755
    A-Developer-Experience A-Testing T-Enhancement
    t3chguy
  14. Apply strictNullChecks to src/rageshake/* vector-im/element-web#24754
    A-Developer-Experience A-Testing T-Enhancement
    weeman1337
  15. Apply strictNullChecks to src/resizer/* vector-im/element-web#24753
    A-Developer-Experience A-Testing T-Enhancement
    kerryarchibald
  16. Apply strictNullChecks to src/utils/exportUtils vector-im/element-web#24822
    A-Developer-Experience T-Enhancement
    kerryarchibald
  17. Apply strictNullChecks to src/components/views/dialogs/devtools/* vector-im/element-web#24836
    A-Developer-Experience A-Testing O-Uncommon S-Tolerable T-Task
    kerryarchibald
  18. Apply strictNullChecks to src/components/structures/auth/* vector-im/element-web#24935
    A-Developer-Experience A-Testing T-Enhancement
    t3chguy
  19. Apply strictNullChecks to src/components/structures/Space* vector-im/element-web#24936
    A-Developer-Experience A-Testing T-Enhancement
    weeman1337
  20. Apply strictNullChecks to src/components/structures/Thread* vector-im/element-web#24938
    A-Developer-Experience A-Testing T-Enhancement
    weeman1337
  21. Apply strictNullChecks to src/components/structures/Space* vector-im/element-web#24937
    A-Developer-Experience A-Testing T-Enhancement
    t3chguy
  22. Apply strictNullChecks to src/components/views/elements/* vector-im/element-web#24940
    A-Developer-Experience A-Testing T-Enhancement
    t3chguy
  23. Apply strictNullChecks to src/components/views/messages/* vector-im/element-web#24939
    A-Developer-Experience A-Testing T-Enhancement
    t3chguy
  24. Apply strictNullChecks to src/components/views/rooms/wysiwyg_composer/* vector-im/element-web#24941
    A-Developer-Experience A-Testing T-Enhancement
    alunturner
  25. Apply strictNullChecks to src/components/views/settings/* vector-im/element-web#25217
    A-Developer-Experience
    kerryarchibald
  26. Apply strictNullChecks to src/contexts/* vector-im/element-web#24944
    A-Developer-Experience A-Testing T-Enhancement
    t3chguy
  27. Apply strictNullChecks to src/hooks/* vector-im/element-web#24945
    A-Developer-Experience A-Testing T-Enhancement
    t3chguy
  28. Apply strictNullChecks to src/utils/*!exportUtils vector-im/element-web#24946
    A-Developer-Experience A-Testing T-Enhancement
    kerryarchibald
  29. Apply strictNullChecks to src/stores/room-list/* vector-im/element-web#24948
    A-Developer-Experience A-Testing T-Enhancement
    weeman1337
  30. Apply strictNullChecks to src/components/views/settings/tabs/* vector-im/element-web#25017
    A-Developer-Experience O-Uncommon S-Tolerable T-Enhancement
    kerryarchibald
  31. Apply strictNullChecks to src/Markdown.ts vector-im/element-web#25086
    A-Developer-Experience A-Testing T-Task
  32. Apply strictNullChecks to src/components/views/voip/* vector-im/element-web#24943
    A-Developer-Experience A-Testing T-Enhancement
    alunturner
  33. Apply strictNullChecks to src/LegacyCallHandler.tsx vector-im/element-web#25087
    A-Developer-Experience A-Testing T-Task
    alunturner
  34. Apply strictNullChecks to src/MatrixClientPeg.ts vector-im/element-web#25088
    A-Developer-Experience A-Testing T-Task
    t3chguy
  35. Apply strictNullChecks to src/utils/local-room.ts vector-im/element-web#25370
    A-Developer-Experience A-Testing T-Task
    weeman1337
  36. Apply strictNullChecks to src/components/views/right_panel/* vector-im/element-web#24752
    A-Developer-Experience A-Testing T-Enhancement
    t3chguy
  37. Apply strictNullChecks to src/stores/right-panel/* vector-im/element-web#24947
    A-Developer-Experience A-Testing T-Enhancement
  38. Apply strictNullChecks to src/components/views/spaces/* vector-im/element-web#24942
    A-Developer-Experience A-Testing T-Enhancement
    weeman1337
  39. Apply strictNullChecks to src/components/structures/RoomView.tsx vector-im/element-web#24838
    A-Developer-Experience A-Testing T-Enhancement
    alunturner
  40. Apply strictNullChecks to src/Searching.ts vector-im/element-web#25344
    A-Developer-Experience O-Uncommon S-Tolerable
    alunturner
  54. Apply strictNulllChecks to src/components/views/rooms/* vector-im/element-web#25345
    kerryarchibald

Have you considered any alternatives?

No response

Additional context

No response
@novocaine novocaine mentioned this issue Apr 28, 2022
Closed
@t3chguy t3chguy mentioned this issue Apr 28, 2022
Closed
4 tasks
@MadLittleMods MadLittleMods mentioned this issue May 6, 2022
Closed
@MadLittleMods MadLittleMods changed the title Use strictNullChecks in matrix-react-sdk Use strictNullChecks in matrix-react-sdk May 6, 2022
This was referenced May 6, 2022
Closed
Closed
Closed
Merged
@MadLittleMods
Copy link
Contributor

MadLittleMods commented May 6, 2022 •
edited
Loading

We currently have 5738 errors when enabling strictNullChecks on matrix-react-sdk.

It would be nice to start using this for all of our new code and only apply strictNullChecks to the changes in the PR (from the git diff). We can run Typescript against the files that changed and filter the errors/warnings to only the line numbers that changed.

Looks like there are some options for ESLint which we could base off of:

For staged files:

Alternatively, we could add an extra assertion that the the number of strictNullChecks can't go up from the number on develop which means you have to fix any new code introduced.

@novocaine
Copy link
Contributor Author

Thanks @MadLittleMods, that seems like a great approach.

If you're interested in helping working through that backlog .. we could use as many hands as we can get to chip away at it

@MadLittleMods MadLittleMods mentioned this issue Jun 1, 2022
Closed
@MadLittleMods MadLittleMods mentioned this issue Nov 8, 2022
Open
3 tasks
@t3chguy t3chguy self-assigned this Nov 14, 2022
@Johennes Johennes mentioned this issue Jan 19, 2023
Closed
This was referenced Feb 3, 2023
Merged
Merged
Closed
@t3chguy
Copy link
Member

t3chguy commented Feb 24, 2023 •
edited
Loading

Things remaining:

Found 18 errors in 9 files.

Errors  Files
     1  ../matrix-js-sdk/src/client.ts:7235
     1  src/components/structures/InteractiveAuth.tsx:113
     4  src/components/structures/RoomView.tsx:1102
     1  src/components/structures/TimelinePanel.tsx:650
     1  src/components/views/dialogs/BaseDialog.tsx:97
     1  src/components/views/dialogs/ScrollableBaseModal.tsx:46
     3  src/components/views/spaces/SpaceTreeLevel.tsx:107
     2  src/Lifecycle.ts:675
     4  src/Searching.ts:488

This was referenced Mar 7, 2023
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 14, 2023
Merged
Merged
This was referenced Apr 4, 2023
Merged
Merged
Merged
This was referenced Apr 12, 2023
Merged
Merged
Merged
@kerryarchibald kerryarchibald mentioned this issue Apr 19, 2023
Merged
3 tasks
This was referenced Apr 19, 2023
Merged
Merged
Merged
@kerryarchibald kerryarchibald mentioned this issue Apr 27, 2023
Merged
3 tasks
@t3chguy t3chguy mentioned this issue Apr 27, 2023
Merged
@t3chguy t3chguy mentioned this issue May 5, 2023
Merged
@t3chguy t3chguy pinned this issue May 10, 2023
@t3chguy t3chguy unpinned this issue May 10, 2023
This was referenced May 10, 2023
Merged
Merged
@kerryarchibald kerryarchibald mentioned this issue May 12, 2023
Merged
3 tasks
This was referenced May 15, 2023
Closed
Merged
Merged
Closed
@t3chguy t3chguy mentioned this issue Jun 15, 2023
Merged
@kerryarchibald kerryarchibald mentioned this issue Jun 16, 2023
Closed
3 tasks
This was referenced Jun 26, 2023
Merged
Merged
Merged
Merged
@t3chguy t3chguy mentioned this issue Jul 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Developer-Experience A-Testing Testing, code coverage, etc. T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable strictNullChecks and noImplicitAny matrix-org/matrix-react-sdk
3 participants
@novocaine @MadLittleMods @t3chguy