Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Eliminate the use of MatrixClientPeg in utils #10910

Merged
merged 7 commits into from
May 23, 2023
Merged

Eliminate the use of MatrixClientPeg in utils #10910

merged 7 commits into from
May 23, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 16, 2023 •
edited by github-actions bot
Loading

For element-hq/element-web#21967

This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label May 16, 2023
@t3chguy t3chguy self-assigned this May 16, 2023
@t3chguy t3chguy mentioned this pull request May 16, 2023
Closed
@t3chguy t3chguy mentioned this pull request May 16, 2023
Merged
@t3chguy
Iterate
88d045e
@t3chguy
Merge branch 'develop' of https://github.com/matrix-org/matrix-react-sdk
c2850eb 
 into t3chguy/kill-client-peg-1

# Conflicts:
#	src/utils/IdentityServerUtils.ts
@t3chguy t3chguy marked this pull request as ready for review May 16, 2023 13:50
@t3chguy t3chguy requested a review from a team as a code owner May 16, 2023 13:50
kerryarchibald
kerryarchibald approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V happy to see this change!
Left a couple of nitpicks, feel free to ignore.

src/utils/pages.ts Outdated Show resolved Hide resolved
src/components/structures/MessagePanel.tsx Outdated Show resolved Hide resolved
@germain-gg germain-gg removed their request for review May 23, 2023 08:28
@t3chguy
Merge branch 'develop' of https://github.com/matrix-org/matrix-react-sdk
f2df2e2 
 into t3chguy/kill-client-peg-1

# Conflicts:
#	src/components/views/rooms/EditMessageComposer.tsx
@t3chguy
Iterate
e5775ce
@t3chguy t3chguy merged commit 30429df into develop May 23, 2023
@t3chguy t3chguy deleted the t3chguy/kill-client-peg-1 branch May 23, 2023 15:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kerryarchibald kerryarchibald kerryarchibald approved these changes

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @kerryarchibald