Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font color of MessageTimestamp different between main timeline and right panel (TimelineCard, ThreadView, ThreadPanel) #22699

Closed
luixxiul opened this issue Jun 30, 2022 · 2 comments
Labels
A-Appearance A-Right-Panel A-Threads A-Timeline good first issue Good for newcomers Help Wanted Extra attention is needed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Maximised-Widgets

Comments

@luixxiul
Copy link

Steps to reproduce

  1. Compare timestamp font color on the main timeline and the right panel

Outcome

What did you expect?

The color should be consistent.

What happened instead?

The font color of the timestamp on right panel (ThreadsList, ThreadView, and TimelineCard) has been specified on this line based on #19669.

Main timeline Right panel
before2 before1
↑ Inherited from the default value ↑ Specified on on this line

Probably should the default color be replaced?

Operating system

Debian

Browser information

Firefox ESR 91

URL for webapp

app.element.io

Application version

No response

Homeserver

No response

Will you send logs?

No

@SimonBrandner SimonBrandner added A-Timeline A-Threads Z-Maximised-Widgets S-Minor Impairs non-critical functionality or suitable workarounds exist A-Appearance O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience good first issue Good for newcomers labels Jun 30, 2022
@kittykat kittykat added the Help Wanted Extra attention is needed label Jul 4, 2022
@turt2live
Copy link
Member

Let's converge on the colour from the main timeline.

nawarajshah added a commit to nawarajshah/matrix-react-sdk that referenced this issue Jan 29, 2023
Fixing the issue of: element-hq/element-web#22699

Changing the color of .mx_MessageTimestamp to make the font color consistent on both Main timeline and Right timeline
@luixxiul
Copy link
Author

luixxiul commented Mar 1, 2023

matrix-org/matrix-react-sdk#10016 seems to have fixed the issue. There should be a percy test about possible color change due to cascading.

The problem is that percy would complain every time you run the test due to the change of timestamp string. I'm adding a test which checks a CSS variable of the timestamp color instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Appearance A-Right-Panel A-Threads A-Timeline good first issue Good for newcomers Help Wanted Extra attention is needed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Maximised-Widgets
Projects
None yet
Development

No branches or pull requests

4 participants