Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presence indicators are off-center in their cutouts #26052

Closed
robintown opened this issue Aug 25, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11472
Closed

Presence indicators are off-center in their cutouts #26052

robintown opened this issue Aug 25, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11472
Assignees
@germain-gg
Labels
A-Avatar A-Presence O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect X-Regression X-Release-Blocker Z-Compound

Comments

@robintown
Copy link
Member

Steps to reproduce

  1. Use a homeserver that has presence enabled
  2. Look at people's avatars in the room list

Outcome

What did you expect?

Presence indicators should be centered within their cutouts

What happened instead?

They're off-center:

Screenshot 2023-08-24 at 21-22-18 Element

Operating system

NixOS unstable

Browser information

Firefox 115.0.2

URL for webapp

develop.element.io

Application version

Element version: fcd8052-react-23897dff4f79-js-5788d9744b76 Olm version: 3.2.14

Homeserver

Not relevant

Will you send logs?

No
@robintown robintown added T-Defect X-Regression S-Tolerable Low/no impact on users A-Avatar A-Presence O-Occasional Affects or can be seen by some users regularly or most users rarely labels Aug 25, 2023
@andybalaam
Copy link
Contributor

@germain-gg was this intended? (I assume this was related to the compound avatars)

@germain-gg germain-gg self-assigned this Aug 25, 2023
germain-gg pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 25, 2023
Fix decorated avatar indicator centering
70473c2 
Fixes element-hq/element-web#26052
@germain-gg germain-gg mentioned this issue Aug 25, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 25, 2023
Fix consistent avatar output for Percy (#11472)
a2dc95e 
* Fix consistent avatar output for Percy

* Fix last room in list clipped

Fixes element-hq/element-web#26049

* Fix decorated avatar indicator centering

Fixes element-hq/element-web#26052

* Fix uploader centering
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 25, 2023
Fix consistent avatar output for Percy (#11472)
7425625 
* Fix consistent avatar output for Percy

* Fix last room in list clipped

Fixes element-hq/element-web#26049

* Fix decorated avatar indicator centering

Fixes element-hq/element-web#26052

* Fix uploader centering
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 25, 2023
Fix consistent avatar output for Percy (#11472)
64f762d 
* Fix consistent avatar output for Percy

* Fix last room in list clipped

Fixes element-hq/element-web#26049

* Fix decorated avatar indicator centering

Fixes element-hq/element-web#26052

* Fix uploader centering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A-Avatar A-Presence O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect X-Regression X-Release-Blocker Z-Compound
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix consistent avatar output for Percy matrix-org/matrix-react-sdk
4 participants
@andybalaam @germain-gg @t3chguy @robintown