Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Set up secure backup" toast ... doesn't #26115

Closed
richvdh opened this issue Sep 4, 2023 · 0 comments · Fixed by matrix-org/matrix-js-sdk#3692
Closed

"Set up secure backup" toast ... doesn't #26115

richvdh opened this issue Sep 4, 2023 · 0 comments · Fixed by matrix-org/matrix-js-sdk#3692
Labels
A-E2EE A-E2EE-Key-Backup O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Team: Crypto

Comments

@richvdh
Copy link
Member

richvdh commented Sep 4, 2023

Steps to reproduce

  1. Register a new account.
  2. Create an encrypted room. You are prompted to "set up secure backup":
    Screenshot_2023-09-04_21-06-58
  3. Click "Continue" and follow the prompts. At the end you are told that secure backup is successful, and Your keys are now being backed up from this device:
    Screenshot_2023-09-04_21-07-36
  4. Send (or receive) an encrypted event.
  5. The key should be uploaded to the server (after a delay). It is not.

Further tests:

  • Attempt to log out. You are (belatedly) told that Secure backup is not set up:
    Screenshot_2023-09-04_21-11-57
    (You can click "Connect to key backup", which does actually do so.)

  • Close your browser tab (without logging out). Log in on a new device, and enter recovery details. You should be able to decrypt the events in the new session (having pulled the keys from key backup), but this doesn't work.

Note that attempting to observe the state by opening the "Security & Privacy" settings panel will actually enable backup. This is arguably a bug in itself.

Outcome

What did you expect?

"Set up secure backup" flow should enable key backup.

What happened instead?

A backup version is created on the server but no keys are backed up to it.

Operating system

No response

Browser information

No response

URL for webapp

https://develop.element.io/

Application version

Element version: 0080395-react-7b62abc14b88-js-5ddd453699a3 Olm version: 3.2.14

Homeserver

No response

Will you send logs?

No

@richvdh richvdh added T-Defect Team: Crypto S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-E2EE A-E2EE-Key-Backup O-Occasional Affects or can be seen by some users regularly or most users rarely labels Sep 4, 2023
richvdh added a commit to matrix-org/matrix-js-sdk that referenced this issue Sep 4, 2023
github-merge-queue bot pushed a commit to matrix-org/matrix-js-sdk that referenced this issue Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE A-E2EE-Key-Backup O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Team: Crypto
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant