Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing a message sent by /spoiler results in removing the spoiler element while preserving inner text #26344

Closed
Gnuxie opened this issue Oct 9, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#11805
Closed

Editing a message sent by /spoiler results in removing the spoiler element while preserving inner text #26344

Gnuxie opened this issue Oct 9, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#11805
Assignees
@Johennes
Labels
A-Message-Editing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@Gnuxie
Copy link

Gnuxie commented Oct 9, 2023

Steps to reproduce

  1. use /spoiler to write a message
  2. edit it because you obviously made a typo
  3. now your message is unspoiled, congratulations 🎉

This has been a bug for a very very long time.

Outcome

It to still be spoiled, but now it really is spoiled.

It is mentioned in this issue #17976 as working, which is true, you can edit spoilers. They just don't stay as spoilers.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No
@Gnuxie Gnuxie added the T-Defect label Oct 9, 2023
@Gnuxie Gnuxie changed the title Editing spoiler text results in removing the spoiler Editing a message sent by /spoiler results in removing the spoiler element while preserving inner text Oct 9, 2023
@weeman1337 weeman1337 added A-Message-Editing S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Oct 10, 2023
Johennes added a commit to matrix-org/matrix-react-sdk that referenced this issue Oct 26, 2023
@Johennes
Deserialise spoilers back into slash command form
1251869 
Fixes: element-hq/element-web#26344
@Johennes Johennes mentioned this issue Oct 26, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Oct 26, 2023
@Johennes
Deserialise spoilers back into slash command form (#11805)
c7c51d7 
* Deserialise spoilers back into slash command form

Fixes: element-hq/element-web#26344

* Appease the linter
gabrc52 added a commit to sipb/matrix-react-sdk that referenced this issue Nov 12, 2023
@gabrc52
Merge tag 'v3.84.0' into sipb
5fb7725 
* Knock on a ask-to-join room if a module wants to join the room when navigating to a room ([\matrix-org#11787](matrix-org#11787)). Contributed by @dhenneke.
* Element-R:  Include crypto info in sentry ([\matrix-org#11798](matrix-org#11798)). Contributed by @florianduros.
* Element-R:  Include crypto info in rageshake ([\matrix-org#11797](matrix-org#11797)). Contributed by @florianduros.
* Element-R: Add current version of the rust-sdk and vodozemac ([\matrix-org#11785](matrix-org#11785)). Contributed by @florianduros.
* Fix unfederated invite dialog ([\matrix-org#9618](matrix-org#9618)). Fixes element-hq/element-meta#1466 and element-hq/element-web#22102. Contributed by @owi92.
* New right panel visual language ([\matrix-org#11664](matrix-org#11664)).
* OIDC: add friendly errors ([\matrix-org#11184](matrix-org#11184)). Fixes element-hq/element-web#25665. Contributed by @kerryarchibald.
* Fix rightpanel hiding scrollbar ([\matrix-org#11831](matrix-org#11831)). Contributed by @kerryarchibald.
* Fix multi-tab session lock on Firefox not being cleared ([\matrix-org#11800](matrix-org#11800)). Fixes element-hq/element-web#26165. Contributed by @ManuelHu.
* Deserialise spoilers back into slash command form ([\matrix-org#11805](matrix-org#11805)). Fixes element-hq/element-web#26344.
* Fix Incorrect message scaling for verification request ([\matrix-org#11793](matrix-org#11793)). Fixes element-hq/element-web#24304. Contributed by @capGoblin.
* Fix: Unable to restore a soft-logged-out session established via SSO ([\matrix-org#11794](matrix-org#11794)). Fixes element-hq/element-web#25957. Contributed by @kerryarchibald.
* Use configurable github issue links more consistently ([\matrix-org#11796](matrix-org#11796)).
* Fix io.element.late_event received_ts vs received_at ([\matrix-org#11789](matrix-org#11789)).
* Make invitation dialog scrollable when infos are too long ([\matrix-org#11753](matrix-org#11753)). Contributed by @nurjinjafar.
* Fix spoiler text-align ([\matrix-org#11790](matrix-org#11790)). Contributed by @ajbura.
* Fix: Right panel keeps showing chat when unmaximizing widget.  ([\matrix-org#11697](matrix-org#11697)). Fixes element-hq/element-web#26265. Contributed by @manancodes.
* Fix margin of invite to room button ([\matrix-org#11780](matrix-org#11780)). Fixes element-hq/element-web#26410.
* Update base64 import ([\matrix-org#11784](matrix-org#11784)).
* Set max size for Element logo in search warning ([\matrix-org#11779](matrix-org#11779)). Fixes element-hq/element-web#26408.
* Fix: emoji size in room header topic, remove obsolete emoji style ([\matrix-org#11757](matrix-org#11757)). Fixes element-hq/element-web#26326. Contributed by @kerryarchibald.
* Fix: Bubble layout design is broken ([\matrix-org#11763](matrix-org#11763)). Fixes element-hq/element-web#25818. Contributed by @manancodes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Johennes Johennes

Labels
A-Message-Editing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deserialise spoilers back into slash command form matrix-org/matrix-react-sdk
3 participants
@Johennes @weeman1337 @Gnuxie