Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer input field misaligned with shield #26851

Closed
andybalaam opened this issue Jan 10, 2024 · 6 comments · Fixed by matrix-org/matrix-react-sdk#12149
Closed

Composer input field misaligned with shield #26851

andybalaam opened this issue Jan 10, 2024 · 6 comments · Fixed by matrix-org/matrix-react-sdk#12149
Labels
A-Composer O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect X-Regression

Comments

@andybalaam
Copy link
Member

Steps to reproduce

  1. In an encrypted room where someone is using an unknown session
  2. The red shield is not aligned with the input entry box of the composer

(I think this has been around for several weeks. Apologies for the delay reporting it)

Outcome

What did you expect?

The shield to be vertically centred relative to the input box.

What happened instead?

image

Operating system

Ubuntu 22.04

Browser information

Recent Firefox and Chromium

URL for webapp

https://develop.element.io

Application version

Element version: 9ea8843-react-1333456fc82b-js-49624d5d7308 Crypto version: Olm 3.2.15

Homeserver

matrix.org

Will you send logs?

No

@dbkr dbkr added S-Tolerable Low/no impact on users O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jan 11, 2024
@nadonomy
Copy link
Contributor

@dbkr I came to report this bug but I'm surprised it's triaged as severity tolerable (the defect is extremely visible) and occasional (it effects all shields - so everyone sees it).

Imo this should be a release blocker even.

@t3chguy
Copy link
Member

t3chguy commented Jan 11, 2024

Release blocker has a defined bar - https://handbook.element.io/books/element-web-team/page/release-blockers - this would not qualify even being bumped to S-Minor & O-Frequent

@Cyberes
Copy link

Cyberes commented Jan 12, 2024

So it will never get fixed?

@t3chguy
Copy link
Member

t3chguy commented Jan 12, 2024

@Cyberes if it was to never be fixed then the issue would be closed.

@nadonomy
Copy link
Contributor

nadonomy commented Jan 13, 2024

Release blocker has a defined bar - https://handbook.element.io/books/element-web-team/page/release-blockers - this would not qualify even being bumped to S-Minor & O-Frequent

Thx for the pointers on the new processes. I think something is broken somewhere if the sum of the processes is highly visible glitches (which are also low hanging fruit) ship to production. The app is visibly broken, to everyone.

What's the best way for us to take more of a common sense approach on this kind of stuff?

@t3chguy
Copy link
Member

t3chguy commented Jan 15, 2024

What's the best way for us to take more of a common sense approach on this kind of stuff?

The bar was set by the last EM, I suggest speaking to the new EM about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect X-Regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants