Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fixed shield alignment on message Input #12149

Merged

Conversation

manancodes
Copy link
Contributor

@manancodes manancodes commented Jan 16, 2024

Checklist

Fixes element-hq/element-web#26851
Signed-off-by: Manan Sadana manancodes.dev@gmail.com

This was the behaviour before the fix:
Screenshot 2024-01-17 at 3 24 14 AM

And this is the behaviour after the fix:
Screenshot 2024-01-17 at 3 24 23 AM

Type: defect


Here's what your changelog entry will look like:

🐛 Bug Fixes

@manancodes manancodes requested a review from a team as a code owner January 16, 2024 22:12
@manancodes manancodes requested review from andybalaam and dbkr January 16, 2024 22:12
@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems labels Jan 16, 2024
@manancodes manancodes marked this pull request as draft January 16, 2024 23:35
@manancodes
Copy link
Contributor Author

Converted to a draft because it needs some more work. The alignment is not right in rooms without encryption. And test screenshots need to be updated.

@manancodes
Copy link
Contributor Author

I am trying to update the snapshots for the tests.

I am using this command:
yarn run test:playwright playwright/e2e/timeline/timeline.spec.ts --update-snapshots

It adds new screenshots with -darwin.png extension but does not update the existing -linux.png files. I'm not very familiar with Playwright. What an I doing wrong?

In the .gitignore file I see that only -linux.png files are allowed to be pushed. So I think it is expected from playwright to create different types of screenshots.

@dbkr
Copy link
Member

dbkr commented Jan 17, 2024

Thanks for this PR, I've updated the branch. I think you asked in the Matrix room but for the record, the answer was that we supply a docker image for the purpose, so yarn test:playwright:screenshots timeline.spec.ts should work.

@manancodes
Copy link
Contributor Author

Awesome. Thanks. I'll update the PR.

@dbkr dbkr added this pull request to the merge queue Jan 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 18, 2024
@dbkr dbkr added this pull request to the merge queue Jan 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 18, 2024
@andybalaam
Copy link
Member

Awesome, thank you @manancodes !

@dbkr dbkr added this pull request to the merge queue Jan 18, 2024
Merged via the queue into matrix-org:develop with commit b3ab5fc Jan 18, 2024
23 checks passed
@t3chguy t3chguy added the backport staging Label to automatically backport PR to staging branch label Jan 18, 2024
RiotRobot pushed a commit that referenced this pull request Jan 18, 2024
* Fixed shield alignment on message Input

* Fixed shield alignment on message Input

* Updated fix

* reversing merged changes

(cherry picked from commit b3ab5fc)
@manancodes manancodes deleted the manancodes/Input_text_shield_misaligned branch January 18, 2024 16:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport staging Label to automatically backport PR to staging branch T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composer input field misaligned with shield
4 participants