Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElementR: client#scheduleAllGroupSessionsForBackup should be deprecated or supported in rust #26912

Open
BillCarsonFr opened this issue Jan 23, 2024 · 2 comments
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust T-Task Tasks for the team like planning Z-Labs

Comments

@BillCarsonFr
Copy link
Member

https://github.com/matrix-org/matrix-js-sdk/blob/3c28cfc96ac6535b357b5e1d3b3180a0f00f87bb/src/client.ts#L3646

    public async scheduleAllGroupSessionsForBackup(): Promise<void> {
        if (!this.crypto) {
            throw new Error("End-to-end encryption disabled");
        }

        await this.crypto.backupManager.scheduleAllGroupSessionsForBackup();
    }

If called in rust crypto will wrongly fail with End-to-end encryption disabled

@BillCarsonFr BillCarsonFr added the A-Element-R Issues affecting the port of Element's crypto layer to Rust label Jan 23, 2024
@BillCarsonFr
Copy link
Member Author

Related #26919

@BillCarsonFr
Copy link
Member Author

Don't need to do it in rust. Mark as deprecated and ignore on rust crypto

@florianduros florianduros added the T-Task Tasks for the team like planning label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust T-Task Tasks for the team like planning Z-Labs
Projects
None yet
Development

No branches or pull requests

2 participants