Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElementR: mark everything in js-sdk that is no longer supported as deprecated #26919

Closed
richvdh opened this issue Jan 24, 2024 · 3 comments · Fixed by matrix-org/matrix-js-sdk#4389
Closed

ElementR: mark everything in js-sdk that is no longer supported as deprecated #26919

richvdh opened this issue Jan 24, 2024 · 3 comments · Fixed by matrix-org/matrix-js-sdk#4389
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust T-Task Tasks for the team like planning Z-Labs

Comments

@richvdh
Copy link
Member

richvdh commented Jan 24, 2024 •
edited
Loading

There are quite a lot of methods in MatrixClient that will not work correctly with Element-R, and which have been replaced, but have yet to be marked as deprecated. Examples:

  • isEventSenderVerified
  • getEventSenderDeviceInfo
  • getOutgoingRoomKeyRequest
  • requestSecret

We should audit for places that use MatrixClient.crypto, and either deprecate them, or plan to fix them.
@richvdh richvdh added the A-Element-R Issues affecting the port of Element's crypto layer to Rust label Jan 24, 2024
@BillCarsonFr
Copy link
Member

There is this also sendSharedHistoryKeys

@BillCarsonFr BillCarsonFr mentioned this issue Jan 24, 2024
Open
@richvdh richvdh mentioned this issue Jan 24, 2024
Open
@florianduros florianduros added the T-Task Tasks for the team like planning label Jan 29, 2024
@BillCarsonFr
Copy link
Member

Quick not on requestSecret there is an API (since 3.5.0) on rust that allows to requestMissingSecrets. It's not an exact mapping but there might be a way to replace it.

@BillCarsonFr
Copy link
Member

Looks like there is a slash command called remakeolm that was available in legacy crypto. No effect in rust

https://github.com/matrix-org/matrix-react-sdk/blob/618462ba06d1d2f64fc589402198529dceae8fe2/src/SlashCommands.tsx#L761

@BillCarsonFr BillCarsonFr mentioned this issue Mar 11, 2024
Closed
@richvdh richvdh mentioned this issue Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust T-Task Tasks for the team like planning Z-Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Element-R: Mark unsupported MatrixClient methods as deprecated matrix-org/matrix-js-sdk
3 participants
@richvdh @florianduros @BillCarsonFr