Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add badge counts & highlights to NotifPanel #3383

Closed
ara4n opened this issue Mar 8, 2017 · 3 comments
Closed

Add badge counts & highlights to NotifPanel #3383

ara4n opened this issue Mar 8, 2017 · 3 comments
Assignees
@turt2live
Labels
P1 S-Tolerable Low/no impact on users T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Mar 8, 2017

Oddvar, Tom, and many others simply don't know it exists.
@ara4n ara4n added I18n T-Defect S-Tolerable Low/no impact on users P1 ui/ux and removed I18n labels Mar 8, 2017
@ara4n
Copy link
Member Author

ara4n commented Mar 8, 2017

Apparently ribot have already fixed this :S

screen shot 2017-03-08 at 14 24 26

@ara4n ara4n added easy and removed design labels Mar 8, 2017
@ara4n ara4n mentioned this issue Apr 23, 2017
Closed
@ara4n
Copy link
Member Author

ara4n commented Apr 23, 2017

this depends on having NotifPanel able to distinguish highlights from non-highlight notifs - and actually display a count!

@ara4n ara4n changed the title Nobody can find NotifPanel or FilePanel Add badge counts & highlights to NotifPanel or FilePanel Apr 23, 2017
@ara4n ara4n changed the title Add badge counts & highlights to NotifPanel or FilePanel Add badge counts & highlights to NotifPanel Sep 18, 2018
@turt2live turt2live self-assigned this Dec 6, 2018
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Dec 6, 2018
@turt2live
Show the number of unread notifications above the bell on the right
173669b 
Fixes element-hq/element-web#3383

This achieves the result by counting up the number of highlights across all rooms and setting that as the badge above the icon. If there are no highlights, nothing is displayed. The red highlight on the bell is done by abusing how the Tinter works: because it has access to the properties of the SVG that we'd need to override it, we give it a collection of colors it should use instead of the theme/tint it is trying to apply. This results in the Tinter using our warning color instead of whatever it was going to apply.

The RightPanel now listens for events to update the count too, otherwise when the user receives a ping they'd have to switch rooms to see the change.
@turt2live turt2live mentioned this issue Dec 6, 2018
Merged
@turt2live
Copy link
Member

Fixed by matrix-org/matrix-react-sdk#2336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
P1 S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turt2live @ara4n