Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12h timestamp collides with encryption icon #4046

Closed
turt2live opened this issue May 26, 2017 · 12 comments
Closed

12h timestamp collides with encryption icon #4046

turt2live opened this issue May 26, 2017 · 12 comments

Comments

@turt2live
Copy link
Member

Description

image

Log: not sent

Version information

  • Platform: web (in-browser)
  • Browser: Chrome 58
  • OS: Windows 10
  • URL: riot.im/develop
@t3chguy
Copy link
Member

t3chguy commented May 26, 2017

where mah mention!?

@turt2live
Copy link
Member Author

@t3chguy

@t3chguy
Copy link
Member

t3chguy commented May 26, 2017

ty

@ara4n
Copy link
Member

ara4n commented May 26, 2017

looks like this is fixed now?

@ara4n ara4n closed this as completed May 26, 2017
@t3chguy
Copy link
Member

t3chguy commented May 26, 2017

image
still broken for me on /develop/

@t3chguy t3chguy reopened this May 26, 2017
@t3chguy
Copy link
Member

t3chguy commented May 26, 2017

@ara4n

@t3chguy
Copy link
Member

t3chguy commented May 27, 2017

undefined
better eg

@lampholder
Copy link
Member

We shouldn't push this live with the overlap glitch, but we shouldn't block the release on this feature... Hopefully the fix is small enough that it's easy to roll in with whatever else we're doing.

@turt2live
Copy link
Member Author

I tried some CSS in Chrome to make this a bit nicer, and can't really decide on a fix. Input appreciated:

  1. Pushing the timestamp 8px to the left (colliding with the hover animation)
    image
  2. Making the sender profile larger by ~10px
    image
    The downside being 24hr time looks a bit weird
    image
  3. Something I haven't considered

@uhoreg
Copy link
Member

uhoreg commented May 30, 2017

How about removing the space before the AM/PM? Or making the font size slightly smaller?

@turt2live
Copy link
Member Author

turt2live commented May 30, 2017

removing the space doesn't save enough space:
image

Doing both font size and removing the space seems to make it fit (11px -> 10px)
image

Edit: And it doesn't look horrible for 24h time. Patch incoming
image

turt2live added a commit to turt2live/matrix-react-sdk that referenced this issue May 30, 2017
Part of addressing element-hq/element-web#4046

Signed-off-by: Travis Ralston <travpc@gmail.com>
@turt2live
Copy link
Member Author

fixed via matrix-org/matrix-react-sdk#969 and #4085

Ended up going with the smaller text and no space solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants