Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messages can (still) be sent in the wrong order after a connection outage #5408

Closed
ara4n opened this issue Oct 24, 2017 · 3 comments
Closed

Messages can (still) be sent in the wrong order after a connection outage #5408

ara4n opened this issue Oct 24, 2017 · 3 comments
Assignees
@turt2live
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Oct 24, 2017

It looks like there can be a race of sorts between messages which are stuck waiting for a server response (during server problems) and those which are explicitly being queued by riot-web due to riot realising that the server is unavailable. As a result, the final ordering of the messages ends up wrong. Not sure if the out-of-order messages are those sent before or immediately after the outage.

Somewhat related to #639
@Nostradamos
Copy link

Happend to me yesterday when there was a huuuge lag. First time i noticed this behaviour.

@lampholder lampholder added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround P2 labels Oct 24, 2017
@ara4n ara4n added P1 and removed P2 labels Aug 20, 2018
@ara4n
Copy link
Member Author

ara4n commented Aug 20, 2018

this is driving me mad. pretty much every time i send a message whilst on bad connectivity, i end up with the first one failed and the next one pending. The pending one then gets sent, but the failed one is stuck failed until i manually resend it, meaning the ordering gets reversed and there's nothing whatsoever i can do :(

@turt2live turt2live self-assigned this Nov 8, 2018
turt2live added a commit to matrix-org/matrix-js-sdk that referenced this issue Nov 8, 2018
@turt2live
Prevent messages from being sent if other messages have failed to send
c9a79bf 
Fixes element-hq/element-web#5408
@turt2live turt2live mentioned this issue Nov 8, 2018
Merged
@turt2live
Copy link
Member

Fixed by matrix-org/matrix-js-sdk#781

@turt2live turt2live mentioned this issue Nov 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@turt2live @ara4n @lampholder @Nostradamos