Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can easily end up in a state where your room list is non-interactable until you fix it #6184

Closed
turt2live opened this issue Feb 16, 2018 · 3 comments
Labels
A-Spaces Spaces, groups, communities P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Release-Blocker
Milestone

Comments

@turt2live
Copy link
Member

Description

The easiest ways I've found to reverse the effect are:

  • Going to the group's settings page and clicking the X in the top right
  • Refreshing riot

Steps to reproduce

  • Open a group's settings
  • Click the "Communities" button at the bottom of the LLP
  • Your room list is now not interactable, even if you manage to escape the groups area
    • To escape the groups area, go to a group's page and click on a room

Version information

  • Platform: web (in-browser)
  • Browser: Chrome 64
  • OS: Windows 10
  • URL: riot.im/develop
@lampholder
Copy link
Member

Oh yeah! That's awful :)

@lampholder lampholder added T-Defect P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround X-Release-Blocker A-Spaces Spaces, groups, communities type:llp labels Feb 21, 2018
@lampholder lampholder added this to the 0.14 milestone Mar 13, 2018
@lampholder
Copy link
Member

Two approaches to address:

  1. disable LLP when you're in settings
  2. reenable roomlist when you're in settings and ensure that all interactions with LLP and roomlist whilst in settings are safe

Option 1. is quick (probably). I think @ara4n was keen we ultimately move in the direction of reenabling the roomlist when you're in settings (though annoyingly I can find a written conclusion on that - @ara4n can you remember what you decided?)

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Mar 16, 2018

I think the decision was not to allow a single interaction on any faded UI - a click which exists User/Group/RoomSettings and returns the UI to its normal opacity. This is arguably orthogonal though.

lukebarnard1 added a commit that referenced this issue Mar 16, 2018
so as to prevent interaction with TagPanel.

Fixes #6184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Spaces Spaces, groups, communities P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Release-Blocker
Projects
None yet
Development

No branches or pull requests

3 participants