Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoomTile badge not updated when RR received #6357

Closed
lukebarnard1 opened this issue Mar 20, 2018 · 5 comments
Closed

RoomTile badge not updated when RR received #6357

lukebarnard1 opened this issue Mar 20, 2018 · 5 comments
Labels
P1 S-Critical Prevents work, causes data loss and/or has no workaround X-Regression
Milestone

Comments

@lukebarnard1
Copy link
Contributor

This was caused by the recent optimisations to RoomTiles (matrix-org/matrix-react-sdk#1801)

@lukebarnard1 lukebarnard1 added P1 X-Regression S-Critical Prevents work, causes data loss and/or has no workaround labels Mar 20, 2018
@lukebarnard1
Copy link
Contributor Author

The immediate fix for this is to make RoomTiles listen for read receipts.

Long term, we want to expose a matrix-js-sdk event that fires when the notification count for a room changes instead of making assumptions about the kind of events that will cause the count to update (as I did with matrix-org/matrix-react-sdk#1801).

@turt2live
Copy link
Member

Potentially related: #6010

@lukebarnard1
Copy link
Contributor Author

@turt2live doubtful - this particular bug was most certainly introduced following RoomList optimisations.

@turt2live
Copy link
Member

:( okay.

@lukebarnard1 lukebarnard1 added this to the 0.14 milestone Mar 20, 2018
@lukebarnard1
Copy link
Contributor Author

The immediate fix for this is to make RoomTiles listen for read receipts.

This causes flickering because RoomList also listens to read receipts. Removing this has been declared invasive so we'll do a different fix: getting room notif count when the room tile is given new props.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 S-Critical Prevents work, causes data loss and/or has no workaround X-Regression
Projects
None yet
Development

No branches or pull requests

2 participants