Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exec must be without quotes in riot-web.desktop #6421

Closed
532910 opened this issue Mar 30, 2018 · 8 comments · Fixed by #10579
Closed

Exec must be without quotes in riot-web.desktop #6421

532910 opened this issue Mar 30, 2018 · 8 comments · Fixed by #10579
Assignees
@jryans
Labels
A-Electron P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Upstream

Comments

@532910
Copy link
Contributor

532910 commented Mar 30, 2018

I'm using riot-web from https://riot.im/packages/debian
It's impossible to run it from menu, as Exec="/opt/Riot/riot-web"
Must be without quotes: Exec=/opt/Riot/riot-web
@t3chguy
Copy link
Member

t3chguy commented Mar 30, 2018

Iirc that file is generated by electron-builder so worth opening an issue there

@532910 532910 mentioned this issue Mar 30, 2018
Closed
@532910
Copy link
Contributor Author

532910 commented Apr 12, 2018

No action for two weeks from the electron-builder side!
Do you realize that now riot-web can not be lauched from the menu?

@532910
Copy link
Contributor Author

532910 commented Apr 12, 2018

The workaround is % cp /usr/share/applications/riot-web.desktop .local/share/applications/ and remove quotes.

@lampholder
Copy link
Member

I'm afraid I don't know anything about how electron works its magic - @c-e-p-x-u-o is the workaround something that can be applied within electron's configuration such that it occurs on app install, or is it something that has to be applied manually by the user after install?

@lampholder lampholder added the S-Major Severely degrades major functionality or product features, with no satisfactory workaround label Apr 16, 2018
@532910
Copy link
Contributor Author

532910 commented Jun 24, 2019

Should be fixed in 21.0.1
electron-userland/electron-builder#2759 (comment)

@t3chguy
Copy link
Member

t3chguy commented Aug 14, 2019

This should just be a case of bumping the electron-builder dependency which will need to be done soon for the sandbox workaround once that is fixed upstream

@jryans
Copy link
Collaborator

jryans commented Aug 16, 2019

I have confirmed this is indeed fixed by upgrading electron-builder.

@jryans jryans self-assigned this Aug 16, 2019
jryans added a commit that referenced this issue Aug 16, 2019
@jryans
Upgrade electron-builder to 21.2.0
24e59cc 
This is meant to help with:

* macOS packaging for Electron 6 (#10473)
* Linux desktop file should not have quotes (#6421)

It did not help with:

* Linux sandbox for Electron 5 (#10509)

Fixes #6421
Part of #10473
@jryans jryans mentioned this issue Aug 16, 2019
Merged
@532910
Copy link
Contributor Author

532910 commented Oct 4, 2019

fixed in riot-web-1.4.2 (may be earlier) debian package
thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Electron P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade electron-builder to 21.2.0 element-hq/element-web
4 participants
@jryans @lampholder @t3chguy @532910