Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password reset ('forgot password') asks user to backup their e2e keys, which is impossible #6681

Closed
26000 opened this issue May 8, 2018 · 5 comments
Closed

Password reset ('forgot password') asks user to backup their e2e keys, which is impossible #6681

26000 opened this issue May 8, 2018 · 5 comments
Assignees
@turt2live
Labels
P1 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Defect

Comments

@26000
Copy link

26000 commented May 8, 2018

Description

When a user tries to reset their password (click on 'Forgot your password?') using an email linked to that account, they are asked to export their E2E room keys. But they don't have access to their keys obviously as they are neither logged in nor have keys in local storage.

Steps to reproduce

  1. Go to https://riot.im/app/ or any other Riot instance.
  2. Enter the login page and click 'Forgot your password?'
  3. Enter your email and password, click 'Send Reset Email'
  4. You get asked to export your keys, which you don't have access to

(on an instance with guest access disabled)

  1. Click 'EXPORT E2E ROOM KEYS'
  2. Enter your passphrase, click 'Export'
  3. See an 'Unknown error' (second image) and an error in console: Error exporting e2e keys: TypeError: Cannot read property 'exportRoomKeys' of null

(on an instance with guest access enabled)

  1. Click 'EXPORT E2E ROOM KEYS'
  2. Enter your passphrase, click 'Export'
  3. Get your guest account E2E keys downloaded, not those of your account. Which is very bad, it's misleading and the user thinks they downloaded their keys, not a temporary account ones.

image
image

What I expect is a window saying that 'if you don't have a backup of your E2E room keys, you will lose all your E2E history'.

Log: unable to, not logged in

Version information

  • Platform: web (in-browser)
  • Browser: Chromium
  • OS: Arch Linux
  • URL: riot.im/develop / riot.im/app / chat.kotobank.ch / any other
@lampholder lampholder added T-Defect ui/ux P1 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users labels May 15, 2018
@lampholder
Copy link
Member

Ugh, this is unnecessarily confusing :(

@t3chguy t3chguy mentioned this issue Jul 16, 2018
Closed
@ara4n
Copy link
Member

ara4n commented Jul 16, 2018

this just resulted in Amandine deleting all her E2E keys >:(

@t3chguy
Copy link
Member

t3chguy commented Jul 16, 2018

@ara4n this or #2671 ?

@ara4n
Copy link
Member

ara4n commented Jul 16, 2018

it was the combination of both. the client had been logged out (by browser deleting local storage); but on prompting to reset the password it lured you into a sense of security by letting you export keys (which are blank). Having exported, without noticing the keys are blank, you then reset the password and lose all your other keys everywhere else due to #2671.

@ara4n
Copy link
Member

ara4n commented Sep 12, 2018

see #2780

@turt2live turt2live mentioned this issue Oct 10, 2018
Closed
@turt2live turt2live self-assigned this Mar 13, 2019
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 13, 2019
@turt2live
Fix 'forgot password' warning to represent the reality of e2ee
eb33af9 
Fixes element-hq/element-web#6681
@turt2live turt2live mentioned this issue Mar 13, 2019
Merged
BBaoVanC added a commit to boba-best/element.boba.best that referenced this issue Sep 14, 2021
@BBaoVanC
Merge tag 'v1.8.5' into build
c10c932 
* Add bubble highlight styling ([\element-hq#6582](matrix-org/matrix-react-sdk#6582)). Fixes element-hq#18295 and element-hq#18295. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Create narrow mode for Composer ([\#6682](matrix-org/matrix-react-sdk#6682)). Fixes element-hq#18533 and element-hq#18533.
* Prefer matrix.to alias links over room id in spaces & share ([\element-hq#6745](matrix-org/matrix-react-sdk#6745)). Fixes element-hq#18796 and element-hq#18796.
* Stop automatic playback of voice messages if a non-voice message is encountered ([\element-hq#6728](matrix-org/matrix-react-sdk#6728)). Fixes element-hq#18850 and element-hq#18850.
* Show call length during a call ([\element-hq#6700](matrix-org/matrix-react-sdk#6700)). Fixes element-hq#18566 and element-hq#18566. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Serialize and retry mass-leave when leaving space ([\element-hq#6737](matrix-org/matrix-react-sdk#6737)). Fixes element-hq#18789 and element-hq#18789.
* Improve form handling in and around space creation ([\#6739](matrix-org/matrix-react-sdk#6739)). Fixes element-hq#18775 and element-hq#18775.
* Split autoplay GIFs and videos into different settings ([\element-hq#6726](matrix-org/matrix-react-sdk#6726)). Fixes element-hq#5771 and element-hq#5771. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Add autoplay for voice messages ([\element-hq#6710](matrix-org/matrix-react-sdk#6710)). Fixes element-hq#18804, element-hq#18715, element-hq#18714 element-hq#17961 and element-hq#18804.
* Allow to use basic html to format invite messages ([\#6703](matrix-org/matrix-react-sdk#6703)). Fixes element-hq#15738 and element-hq#15738. Contributed by [skolmer](https://github.com/skolmer).
* Allow widgets, when eligible, to interact with more rooms as per MSC2762 ([\element-hq#6684](matrix-org/matrix-react-sdk#6684)).
* Remove arbitrary limits from send/receive events for widgets ([\element-hq#6719](matrix-org/matrix-react-sdk#6719)). Fixes element-hq#17994 and element-hq#17994.
* Reload suggested rooms if we see the state change down /sync ([\element-hq#6715](matrix-org/matrix-react-sdk#6715)). Fixes element-hq#18761 and element-hq#18761.
* When creating private spaces, make the initial rooms restricted if supported ([\element-hq#6721](matrix-org/matrix-react-sdk#6721)). Fixes element-hq#18722 and element-hq#18722.
* Threading exploration work ([\element-hq#6658](matrix-org/matrix-react-sdk#6658)). Fixes element-hq#18532 and element-hq#18532.
* Default to `Don't leave any` when leaving a space ([\element-hq#6697](matrix-org/matrix-react-sdk#6697)). Fixes element-hq#18592 and element-hq#18592. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Special case redaction event sending from widgets per MSC2762 ([\element-hq#6686](matrix-org/matrix-react-sdk#6686)). Fixes element-hq#18573 and element-hq#18573.
* Add active speaker indicators ([\element-hq#6639](matrix-org/matrix-react-sdk#6639)). Fixes element-hq#17627 and element-hq#17627. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Increase general app performance by optimizing layers ([\element-hq#6644](matrix-org/matrix-react-sdk#6644)). Fixes element-hq#18730 and element-hq#18730. Contributed by [Palid](https://github.com/Palid).
* Fix autocomplete not having y-scroll ([\element-hq#6802](matrix-org/matrix-react-sdk#6802)).
* Fix emoji picker and stickerpicker not appearing correctly when opened ([\element-hq#6801](matrix-org/matrix-react-sdk#6801)).
* Debounce read marker update on scroll ([\element-hq#6774](matrix-org/matrix-react-sdk#6774)).
* Fix Space creation wizard go to my first room button behaviour ([\element-hq#6748](matrix-org/matrix-react-sdk#6748)). Fixes element-hq#18764 and element-hq#18764.
* Fix scroll being stuck at bottom ([\element-hq#6751](matrix-org/matrix-react-sdk#6751)). Fixes element-hq#18903 and element-hq#18903.
* Fix widgets not remembering identity verification when asked to. ([\element-hq#6742](matrix-org/matrix-react-sdk#6742)). Fixes element-hq#15631 and element-hq#15631.
* Add missing pluralisation i18n strings for Spaces ([\element-hq#6738](matrix-org/matrix-react-sdk#6738)). Fixes element-hq#18780 and element-hq#18780.
* Make ForgotPassword UX slightly more user friendly ([\#6636](matrix-org/matrix-react-sdk#6636)). Fixes element-hq#11531 and element-hq#11531. Contributed by [Palid](https://github.com/Palid).
* Don't context switch room on SpaceStore ready as it can break permalinks ([\element-hq#6730](matrix-org/matrix-react-sdk#6730)). Fixes element-hq#17974 and element-hq#17974.
* Fix explore rooms button not working during space creation wizard ([\element-hq#6729](matrix-org/matrix-react-sdk#6729)). Fixes element-hq#18762 and element-hq#18762.
* Fix bug where one party's media would sometimes not be shown ([\element-hq#6731](matrix-org/matrix-react-sdk#6731)).
* Only make the initial space rooms suggested by default ([\element-hq#6714](matrix-org/matrix-react-sdk#6714)). Fixes element-hq#18760 and element-hq#18760.
* Replace fake username in EventTilePreview with a proper loading state ([\element-hq#6702](matrix-org/matrix-react-sdk#6702)). Fixes element-hq#15897 and element-hq#15897. Contributed by [skolmer](https://github.com/skolmer).
* Don't send prehistorical events to widgets during decryption at startup ([\element-hq#6695](matrix-org/matrix-react-sdk#6695)). Fixes element-hq#18060 and element-hq#18060.
* When creating subspaces properly set restricted join rule ([\element-hq#6725](matrix-org/matrix-react-sdk#6725)). Fixes element-hq#18797 and element-hq#18797.
* Fix the Image View not openning for some pinned messages ([\element-hq#6723](matrix-org/matrix-react-sdk#6723)). Fixes element-hq#18422 and element-hq#18422. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Show autocomplete sections vertically ([\element-hq#6722](matrix-org/matrix-react-sdk#6722)). Fixes element-hq#18860 and element-hq#18860. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix EmojiPicker filtering to lower case emojibase data strings ([\element-hq#6717](matrix-org/matrix-react-sdk#6717)). Fixes element-hq#18686 and element-hq#18686.
* Clear currentRoomId when viewing home page, fixing document title ([\element-hq#6716](matrix-org/matrix-react-sdk#6716)). Fixes element-hq#18668 and element-hq#18668.
* Fix membership updates to Spaces not applying in real-time ([\element-hq#6713](matrix-org/matrix-react-sdk#6713)). Fixes element-hq#18737 and element-hq#18737.
* Don't show a double stacked invite modals when inviting to Spaces ([\element-hq#6698](matrix-org/matrix-react-sdk#6698)). Fixes element-hq#18745 and element-hq#18745. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Remove non-functional DuckDuckGo Autocomplete Provider ([\element-hq#6712](matrix-org/matrix-react-sdk#6712)). Fixes element-hq#18778 and element-hq#18778.
* Filter members on `MemberList` load ([\element-hq#6708](matrix-org/matrix-react-sdk#6708)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix improper voice messages being produced in Firefox and sometimes other browsers. ([\element-hq#6696](matrix-org/matrix-react-sdk#6696)). Fixes element-hq#18587 and element-hq#18587.
* Fix client forgetting which capabilities a widget was approved for ([\element-hq#6685](matrix-org/matrix-react-sdk#6685)). Fixes element-hq#18786 and element-hq#18786.
* Fix left panel widgets not remembering collapsed state ([\element-hq#6687](matrix-org/matrix-react-sdk#6687)). Fixes element-hq#17803 and element-hq#17803.
* Fix changelog link colour back to blue ([\element-hq#6692](matrix-org/matrix-react-sdk#6692)). Fixes element-hq#18726 and element-hq#18726.
* Soften codeblock border color ([\element-hq#6564](matrix-org/matrix-react-sdk#6564)). Fixes element-hq#18367 and element-hq#18367. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Pause ringing more aggressively ([\element-hq#6691](matrix-org/matrix-react-sdk#6691)). Fixes element-hq#18588 and element-hq#18588. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix command autocomplete ([\element-hq#6680](matrix-org/matrix-react-sdk#6680)). Fixes element-hq#18670 and element-hq#18670. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Don't re-sort the room-list based on profile/status changes ([\element-hq#6595](matrix-org/matrix-react-sdk#6595)). Fixes #110 and #110. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix codeblock formatting with syntax highlighting on ([\element-hq#6681](matrix-org/matrix-react-sdk#6681)). Fixes element-hq#18739 element-hq#18365 and element-hq#18739. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Add padding to the Add button in the notification settings ([\element-hq#6665](matrix-org/matrix-react-sdk#6665)). Fixes element-hq#18706 and element-hq#18706. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
coolmic added a commit to livegen/riot-web that referenced this issue Sep 16, 2021
@coolmic
Merge tag 'v1.8.5' into deploy-auto
fa61e51 
* Add bubble highlight styling ([\element-hq#6582](matrix-org/matrix-react-sdk#6582)). Fixes element-hq#18295 and element-hq#18295. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Create narrow mode for Composer ([\#6682](matrix-org/matrix-react-sdk#6682)). Fixes element-hq#18533 and element-hq#18533.
* Prefer matrix.to alias links over room id in spaces & share ([\element-hq#6745](matrix-org/matrix-react-sdk#6745)). Fixes element-hq#18796 and element-hq#18796.
* Stop automatic playback of voice messages if a non-voice message is encountered ([\element-hq#6728](matrix-org/matrix-react-sdk#6728)). Fixes element-hq#18850 and element-hq#18850.
* Show call length during a call ([\element-hq#6700](matrix-org/matrix-react-sdk#6700)). Fixes element-hq#18566 and element-hq#18566. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Serialize and retry mass-leave when leaving space ([\element-hq#6737](matrix-org/matrix-react-sdk#6737)). Fixes element-hq#18789 and element-hq#18789.
* Improve form handling in and around space creation ([\#6739](matrix-org/matrix-react-sdk#6739)). Fixes element-hq#18775 and element-hq#18775.
* Split autoplay GIFs and videos into different settings ([\element-hq#6726](matrix-org/matrix-react-sdk#6726)). Fixes element-hq#5771 and element-hq#5771. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Add autoplay for voice messages ([\element-hq#6710](matrix-org/matrix-react-sdk#6710)). Fixes element-hq#18804, element-hq#18715, element-hq#18714 element-hq#17961 and element-hq#18804.
* Allow to use basic html to format invite messages ([\#6703](matrix-org/matrix-react-sdk#6703)). Fixes element-hq#15738 and element-hq#15738. Contributed by [skolmer](https://github.com/skolmer).
* Allow widgets, when eligible, to interact with more rooms as per MSC2762 ([\element-hq#6684](matrix-org/matrix-react-sdk#6684)).
* Remove arbitrary limits from send/receive events for widgets ([\element-hq#6719](matrix-org/matrix-react-sdk#6719)). Fixes element-hq#17994 and element-hq#17994.
* Reload suggested rooms if we see the state change down /sync ([\element-hq#6715](matrix-org/matrix-react-sdk#6715)). Fixes element-hq#18761 and element-hq#18761.
* When creating private spaces, make the initial rooms restricted if supported ([\element-hq#6721](matrix-org/matrix-react-sdk#6721)). Fixes element-hq#18722 and element-hq#18722.
* Threading exploration work ([\element-hq#6658](matrix-org/matrix-react-sdk#6658)). Fixes element-hq#18532 and element-hq#18532.
* Default to `Don't leave any` when leaving a space ([\element-hq#6697](matrix-org/matrix-react-sdk#6697)). Fixes element-hq#18592 and element-hq#18592. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Special case redaction event sending from widgets per MSC2762 ([\element-hq#6686](matrix-org/matrix-react-sdk#6686)). Fixes element-hq#18573 and element-hq#18573.
* Add active speaker indicators ([\element-hq#6639](matrix-org/matrix-react-sdk#6639)). Fixes element-hq#17627 and element-hq#17627. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Increase general app performance by optimizing layers ([\element-hq#6644](matrix-org/matrix-react-sdk#6644)). Fixes element-hq#18730 and element-hq#18730. Contributed by [Palid](https://github.com/Palid).
* Fix autocomplete not having y-scroll ([\element-hq#6802](matrix-org/matrix-react-sdk#6802)).
* Fix emoji picker and stickerpicker not appearing correctly when opened ([\element-hq#6801](matrix-org/matrix-react-sdk#6801)).
* Debounce read marker update on scroll ([\element-hq#6774](matrix-org/matrix-react-sdk#6774)).
* Fix Space creation wizard go to my first room button behaviour ([\element-hq#6748](matrix-org/matrix-react-sdk#6748)). Fixes element-hq#18764 and element-hq#18764.
* Fix scroll being stuck at bottom ([\element-hq#6751](matrix-org/matrix-react-sdk#6751)). Fixes element-hq#18903 and element-hq#18903.
* Fix widgets not remembering identity verification when asked to. ([\element-hq#6742](matrix-org/matrix-react-sdk#6742)). Fixes element-hq#15631 and element-hq#15631.
* Add missing pluralisation i18n strings for Spaces ([\element-hq#6738](matrix-org/matrix-react-sdk#6738)). Fixes element-hq#18780 and element-hq#18780.
* Make ForgotPassword UX slightly more user friendly ([\#6636](matrix-org/matrix-react-sdk#6636)). Fixes element-hq#11531 and element-hq#11531. Contributed by [Palid](https://github.com/Palid).
* Don't context switch room on SpaceStore ready as it can break permalinks ([\element-hq#6730](matrix-org/matrix-react-sdk#6730)). Fixes element-hq#17974 and element-hq#17974.
* Fix explore rooms button not working during space creation wizard ([\element-hq#6729](matrix-org/matrix-react-sdk#6729)). Fixes element-hq#18762 and element-hq#18762.
* Fix bug where one party's media would sometimes not be shown ([\element-hq#6731](matrix-org/matrix-react-sdk#6731)).
* Only make the initial space rooms suggested by default ([\element-hq#6714](matrix-org/matrix-react-sdk#6714)). Fixes element-hq#18760 and element-hq#18760.
* Replace fake username in EventTilePreview with a proper loading state ([\element-hq#6702](matrix-org/matrix-react-sdk#6702)). Fixes element-hq#15897 and element-hq#15897. Contributed by [skolmer](https://github.com/skolmer).
* Don't send prehistorical events to widgets during decryption at startup ([\element-hq#6695](matrix-org/matrix-react-sdk#6695)). Fixes element-hq#18060 and element-hq#18060.
* When creating subspaces properly set restricted join rule ([\element-hq#6725](matrix-org/matrix-react-sdk#6725)). Fixes element-hq#18797 and element-hq#18797.
* Fix the Image View not openning for some pinned messages ([\element-hq#6723](matrix-org/matrix-react-sdk#6723)). Fixes element-hq#18422 and element-hq#18422. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Show autocomplete sections vertically ([\element-hq#6722](matrix-org/matrix-react-sdk#6722)). Fixes element-hq#18860 and element-hq#18860. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix EmojiPicker filtering to lower case emojibase data strings ([\element-hq#6717](matrix-org/matrix-react-sdk#6717)). Fixes element-hq#18686 and element-hq#18686.
* Clear currentRoomId when viewing home page, fixing document title ([\element-hq#6716](matrix-org/matrix-react-sdk#6716)). Fixes element-hq#18668 and element-hq#18668.
* Fix membership updates to Spaces not applying in real-time ([\element-hq#6713](matrix-org/matrix-react-sdk#6713)). Fixes element-hq#18737 and element-hq#18737.
* Don't show a double stacked invite modals when inviting to Spaces ([\element-hq#6698](matrix-org/matrix-react-sdk#6698)). Fixes element-hq#18745 and element-hq#18745. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Remove non-functional DuckDuckGo Autocomplete Provider ([\element-hq#6712](matrix-org/matrix-react-sdk#6712)). Fixes element-hq#18778 and element-hq#18778.
* Filter members on `MemberList` load ([\element-hq#6708](matrix-org/matrix-react-sdk#6708)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix improper voice messages being produced in Firefox and sometimes other browsers. ([\element-hq#6696](matrix-org/matrix-react-sdk#6696)). Fixes element-hq#18587 and element-hq#18587.
* Fix client forgetting which capabilities a widget was approved for ([\element-hq#6685](matrix-org/matrix-react-sdk#6685)). Fixes element-hq#18786 and element-hq#18786.
* Fix left panel widgets not remembering collapsed state ([\element-hq#6687](matrix-org/matrix-react-sdk#6687)). Fixes element-hq#17803 and element-hq#17803.
* Fix changelog link colour back to blue ([\element-hq#6692](matrix-org/matrix-react-sdk#6692)). Fixes element-hq#18726 and element-hq#18726.
* Soften codeblock border color ([\element-hq#6564](matrix-org/matrix-react-sdk#6564)). Fixes element-hq#18367 and element-hq#18367. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Pause ringing more aggressively ([\element-hq#6691](matrix-org/matrix-react-sdk#6691)). Fixes element-hq#18588 and element-hq#18588. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix command autocomplete ([\element-hq#6680](matrix-org/matrix-react-sdk#6680)). Fixes element-hq#18670 and element-hq#18670. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Don't re-sort the room-list based on profile/status changes ([\element-hq#6595](matrix-org/matrix-react-sdk#6595)). Fixes #110 and #110. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix codeblock formatting with syntax highlighting on ([\element-hq#6681](matrix-org/matrix-react-sdk#6681)). Fixes element-hq#18739 element-hq#18365 and element-hq#18739. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Add padding to the Add button in the notification settings ([\element-hq#6665](matrix-org/matrix-react-sdk#6665)). Fixes element-hq#18706 and element-hq#18706. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
williamkray added a commit to williamkray/element-web that referenced this issue Nov 9, 2021
@williamkray
Merge tag 'v1.8.5' into develop
297bfac 
* Add bubble highlight styling ([\element-hq#6582](matrix-org/matrix-react-sdk#6582)). Fixes element-hq#18295 and element-hq#18295. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Create narrow mode for Composer ([\#6682](matrix-org/matrix-react-sdk#6682)). Fixes element-hq#18533 and element-hq#18533.
* Prefer matrix.to alias links over room id in spaces & share ([\element-hq#6745](matrix-org/matrix-react-sdk#6745)). Fixes element-hq#18796 and element-hq#18796.
* Stop automatic playback of voice messages if a non-voice message is encountered ([\element-hq#6728](matrix-org/matrix-react-sdk#6728)). Fixes element-hq#18850 and element-hq#18850.
* Show call length during a call ([\element-hq#6700](matrix-org/matrix-react-sdk#6700)). Fixes element-hq#18566 and element-hq#18566. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Serialize and retry mass-leave when leaving space ([\element-hq#6737](matrix-org/matrix-react-sdk#6737)). Fixes element-hq#18789 and element-hq#18789.
* Improve form handling in and around space creation ([\#6739](matrix-org/matrix-react-sdk#6739)). Fixes element-hq#18775 and element-hq#18775.
* Split autoplay GIFs and videos into different settings ([\element-hq#6726](matrix-org/matrix-react-sdk#6726)). Fixes element-hq#5771 and element-hq#5771. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Add autoplay for voice messages ([\element-hq#6710](matrix-org/matrix-react-sdk#6710)). Fixes element-hq#18804, element-hq#18715, element-hq#18714 element-hq#17961 and element-hq#18804.
* Allow to use basic html to format invite messages ([\#6703](matrix-org/matrix-react-sdk#6703)). Fixes element-hq#15738 and element-hq#15738. Contributed by [skolmer](https://github.com/skolmer).
* Allow widgets, when eligible, to interact with more rooms as per MSC2762 ([\element-hq#6684](matrix-org/matrix-react-sdk#6684)).
* Remove arbitrary limits from send/receive events for widgets ([\element-hq#6719](matrix-org/matrix-react-sdk#6719)). Fixes element-hq#17994 and element-hq#17994.
* Reload suggested rooms if we see the state change down /sync ([\element-hq#6715](matrix-org/matrix-react-sdk#6715)). Fixes element-hq#18761 and element-hq#18761.
* When creating private spaces, make the initial rooms restricted if supported ([\element-hq#6721](matrix-org/matrix-react-sdk#6721)). Fixes element-hq#18722 and element-hq#18722.
* Threading exploration work ([\element-hq#6658](matrix-org/matrix-react-sdk#6658)). Fixes element-hq#18532 and element-hq#18532.
* Default to `Don't leave any` when leaving a space ([\element-hq#6697](matrix-org/matrix-react-sdk#6697)). Fixes element-hq#18592 and element-hq#18592. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Special case redaction event sending from widgets per MSC2762 ([\element-hq#6686](matrix-org/matrix-react-sdk#6686)). Fixes element-hq#18573 and element-hq#18573.
* Add active speaker indicators ([\element-hq#6639](matrix-org/matrix-react-sdk#6639)). Fixes element-hq#17627 and element-hq#17627. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Increase general app performance by optimizing layers ([\element-hq#6644](matrix-org/matrix-react-sdk#6644)). Fixes element-hq#18730 and element-hq#18730. Contributed by [Palid](https://github.com/Palid).
* Fix autocomplete not having y-scroll ([\element-hq#6802](matrix-org/matrix-react-sdk#6802)).
* Fix emoji picker and stickerpicker not appearing correctly when opened ([\element-hq#6801](matrix-org/matrix-react-sdk#6801)).
* Debounce read marker update on scroll ([\element-hq#6774](matrix-org/matrix-react-sdk#6774)).
* Fix Space creation wizard go to my first room button behaviour ([\element-hq#6748](matrix-org/matrix-react-sdk#6748)). Fixes element-hq#18764 and element-hq#18764.
* Fix scroll being stuck at bottom ([\element-hq#6751](matrix-org/matrix-react-sdk#6751)). Fixes element-hq#18903 and element-hq#18903.
* Fix widgets not remembering identity verification when asked to. ([\element-hq#6742](matrix-org/matrix-react-sdk#6742)). Fixes element-hq#15631 and element-hq#15631.
* Add missing pluralisation i18n strings for Spaces ([\element-hq#6738](matrix-org/matrix-react-sdk#6738)). Fixes element-hq#18780 and element-hq#18780.
* Make ForgotPassword UX slightly more user friendly ([\#6636](matrix-org/matrix-react-sdk#6636)). Fixes element-hq#11531 and element-hq#11531. Contributed by [Palid](https://github.com/Palid).
* Don't context switch room on SpaceStore ready as it can break permalinks ([\element-hq#6730](matrix-org/matrix-react-sdk#6730)). Fixes element-hq#17974 and element-hq#17974.
* Fix explore rooms button not working during space creation wizard ([\element-hq#6729](matrix-org/matrix-react-sdk#6729)). Fixes element-hq#18762 and element-hq#18762.
* Fix bug where one party's media would sometimes not be shown ([\element-hq#6731](matrix-org/matrix-react-sdk#6731)).
* Only make the initial space rooms suggested by default ([\element-hq#6714](matrix-org/matrix-react-sdk#6714)). Fixes element-hq#18760 and element-hq#18760.
* Replace fake username in EventTilePreview with a proper loading state ([\element-hq#6702](matrix-org/matrix-react-sdk#6702)). Fixes element-hq#15897 and element-hq#15897. Contributed by [skolmer](https://github.com/skolmer).
* Don't send prehistorical events to widgets during decryption at startup ([\element-hq#6695](matrix-org/matrix-react-sdk#6695)). Fixes element-hq#18060 and element-hq#18060.
* When creating subspaces properly set restricted join rule ([\element-hq#6725](matrix-org/matrix-react-sdk#6725)). Fixes element-hq#18797 and element-hq#18797.
* Fix the Image View not openning for some pinned messages ([\element-hq#6723](matrix-org/matrix-react-sdk#6723)). Fixes element-hq#18422 and element-hq#18422. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Show autocomplete sections vertically ([\element-hq#6722](matrix-org/matrix-react-sdk#6722)). Fixes element-hq#18860 and element-hq#18860. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix EmojiPicker filtering to lower case emojibase data strings ([\element-hq#6717](matrix-org/matrix-react-sdk#6717)). Fixes element-hq#18686 and element-hq#18686.
* Clear currentRoomId when viewing home page, fixing document title ([\element-hq#6716](matrix-org/matrix-react-sdk#6716)). Fixes element-hq#18668 and element-hq#18668.
* Fix membership updates to Spaces not applying in real-time ([\element-hq#6713](matrix-org/matrix-react-sdk#6713)). Fixes element-hq#18737 and element-hq#18737.
* Don't show a double stacked invite modals when inviting to Spaces ([\element-hq#6698](matrix-org/matrix-react-sdk#6698)). Fixes element-hq#18745 and element-hq#18745. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Remove non-functional DuckDuckGo Autocomplete Provider ([\element-hq#6712](matrix-org/matrix-react-sdk#6712)). Fixes element-hq#18778 and element-hq#18778.
* Filter members on `MemberList` load ([\element-hq#6708](matrix-org/matrix-react-sdk#6708)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix improper voice messages being produced in Firefox and sometimes other browsers. ([\element-hq#6696](matrix-org/matrix-react-sdk#6696)). Fixes element-hq#18587 and element-hq#18587.
* Fix client forgetting which capabilities a widget was approved for ([\element-hq#6685](matrix-org/matrix-react-sdk#6685)). Fixes element-hq#18786 and element-hq#18786.
* Fix left panel widgets not remembering collapsed state ([\element-hq#6687](matrix-org/matrix-react-sdk#6687)). Fixes element-hq#17803 and element-hq#17803.
* Fix changelog link colour back to blue ([\element-hq#6692](matrix-org/matrix-react-sdk#6692)). Fixes element-hq#18726 and element-hq#18726.
* Soften codeblock border color ([\element-hq#6564](matrix-org/matrix-react-sdk#6564)). Fixes element-hq#18367 and element-hq#18367. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Pause ringing more aggressively ([\element-hq#6691](matrix-org/matrix-react-sdk#6691)). Fixes element-hq#18588 and element-hq#18588. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix command autocomplete ([\element-hq#6680](matrix-org/matrix-react-sdk#6680)). Fixes element-hq#18670 and element-hq#18670. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Don't re-sort the room-list based on profile/status changes ([\element-hq#6595](matrix-org/matrix-react-sdk#6595)). Fixes #110 and #110. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix codeblock formatting with syntax highlighting on ([\element-hq#6681](matrix-org/matrix-react-sdk#6681)). Fixes element-hq#18739 element-hq#18365 and element-hq#18739. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Add padding to the Add button in the notification settings ([\element-hq#6665](matrix-org/matrix-react-sdk#6665)). Fixes element-hq#18706 and element-hq#18706. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
awesome-manuel pushed a commit to Awesome-Technologies/element-web that referenced this issue May 25, 2023
@awesome-michael
Merge tag 'v1.8.5' into AMP.chat
933b2e4 
* Add bubble highlight styling ([\element-hq#6582](matrix-org/matrix-react-sdk#6582)). Fixes element-hq#18295 and element-hq#18295. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Create narrow mode for Composer ([\#6682](matrix-org/matrix-react-sdk#6682)). Fixes element-hq#18533 and element-hq#18533.
* Prefer matrix.to alias links over room id in spaces & share ([\element-hq#6745](matrix-org/matrix-react-sdk#6745)). Fixes element-hq#18796 and element-hq#18796.
* Stop automatic playback of voice messages if a non-voice message is encountered ([\element-hq#6728](matrix-org/matrix-react-sdk#6728)). Fixes element-hq#18850 and element-hq#18850.
* Show call length during a call ([\element-hq#6700](matrix-org/matrix-react-sdk#6700)). Fixes element-hq#18566 and element-hq#18566. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Serialize and retry mass-leave when leaving space ([\element-hq#6737](matrix-org/matrix-react-sdk#6737)). Fixes element-hq#18789 and element-hq#18789.
* Improve form handling in and around space creation ([\#6739](matrix-org/matrix-react-sdk#6739)). Fixes element-hq#18775 and element-hq#18775.
* Split autoplay GIFs and videos into different settings ([\element-hq#6726](matrix-org/matrix-react-sdk#6726)). Fixes element-hq#5771 and element-hq#5771. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Add autoplay for voice messages ([\element-hq#6710](matrix-org/matrix-react-sdk#6710)). Fixes element-hq#18804, element-hq#18715, element-hq#18714 element-hq#17961 and element-hq#18804.
* Allow to use basic html to format invite messages ([\#6703](matrix-org/matrix-react-sdk#6703)). Fixes element-hq#15738 and element-hq#15738. Contributed by [skolmer](https://github.com/skolmer).
* Allow widgets, when eligible, to interact with more rooms as per MSC2762 ([\element-hq#6684](matrix-org/matrix-react-sdk#6684)).
* Remove arbitrary limits from send/receive events for widgets ([\element-hq#6719](matrix-org/matrix-react-sdk#6719)). Fixes element-hq#17994 and element-hq#17994.
* Reload suggested rooms if we see the state change down /sync ([\element-hq#6715](matrix-org/matrix-react-sdk#6715)). Fixes element-hq#18761 and element-hq#18761.
* When creating private spaces, make the initial rooms restricted if supported ([\element-hq#6721](matrix-org/matrix-react-sdk#6721)). Fixes element-hq#18722 and element-hq#18722.
* Threading exploration work ([\element-hq#6658](matrix-org/matrix-react-sdk#6658)). Fixes element-hq#18532 and element-hq#18532.
* Default to `Don't leave any` when leaving a space ([\element-hq#6697](matrix-org/matrix-react-sdk#6697)). Fixes element-hq#18592 and element-hq#18592. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Special case redaction event sending from widgets per MSC2762 ([\element-hq#6686](matrix-org/matrix-react-sdk#6686)). Fixes element-hq#18573 and element-hq#18573.
* Add active speaker indicators ([\element-hq#6639](matrix-org/matrix-react-sdk#6639)). Fixes element-hq#17627 and element-hq#17627. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Increase general app performance by optimizing layers ([\element-hq#6644](matrix-org/matrix-react-sdk#6644)). Fixes element-hq#18730 and element-hq#18730. Contributed by [Palid](https://github.com/Palid).
* Fix autocomplete not having y-scroll ([\element-hq#6802](matrix-org/matrix-react-sdk#6802)).
* Fix emoji picker and stickerpicker not appearing correctly when opened ([\element-hq#6801](matrix-org/matrix-react-sdk#6801)).
* Debounce read marker update on scroll ([\element-hq#6774](matrix-org/matrix-react-sdk#6774)).
* Fix Space creation wizard go to my first room button behaviour ([\element-hq#6748](matrix-org/matrix-react-sdk#6748)). Fixes element-hq#18764 and element-hq#18764.
* Fix scroll being stuck at bottom ([\element-hq#6751](matrix-org/matrix-react-sdk#6751)). Fixes element-hq#18903 and element-hq#18903.
* Fix widgets not remembering identity verification when asked to. ([\element-hq#6742](matrix-org/matrix-react-sdk#6742)). Fixes element-hq#15631 and element-hq#15631.
* Add missing pluralisation i18n strings for Spaces ([\element-hq#6738](matrix-org/matrix-react-sdk#6738)). Fixes element-hq#18780 and element-hq#18780.
* Make ForgotPassword UX slightly more user friendly ([\#6636](matrix-org/matrix-react-sdk#6636)). Fixes element-hq#11531 and element-hq#11531. Contributed by [Palid](https://github.com/Palid).
* Don't context switch room on SpaceStore ready as it can break permalinks ([\element-hq#6730](matrix-org/matrix-react-sdk#6730)). Fixes element-hq#17974 and element-hq#17974.
* Fix explore rooms button not working during space creation wizard ([\element-hq#6729](matrix-org/matrix-react-sdk#6729)). Fixes element-hq#18762 and element-hq#18762.
* Fix bug where one party's media would sometimes not be shown ([\element-hq#6731](matrix-org/matrix-react-sdk#6731)).
* Only make the initial space rooms suggested by default ([\element-hq#6714](matrix-org/matrix-react-sdk#6714)). Fixes element-hq#18760 and element-hq#18760.
* Replace fake username in EventTilePreview with a proper loading state ([\element-hq#6702](matrix-org/matrix-react-sdk#6702)). Fixes element-hq#15897 and element-hq#15897. Contributed by [skolmer](https://github.com/skolmer).
* Don't send prehistorical events to widgets during decryption at startup ([\element-hq#6695](matrix-org/matrix-react-sdk#6695)). Fixes element-hq#18060 and element-hq#18060.
* When creating subspaces properly set restricted join rule ([\element-hq#6725](matrix-org/matrix-react-sdk#6725)). Fixes element-hq#18797 and element-hq#18797.
* Fix the Image View not openning for some pinned messages ([\element-hq#6723](matrix-org/matrix-react-sdk#6723)). Fixes element-hq#18422 and element-hq#18422. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Show autocomplete sections vertically ([\element-hq#6722](matrix-org/matrix-react-sdk#6722)). Fixes element-hq#18860 and element-hq#18860. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix EmojiPicker filtering to lower case emojibase data strings ([\element-hq#6717](matrix-org/matrix-react-sdk#6717)). Fixes element-hq#18686 and element-hq#18686.
* Clear currentRoomId when viewing home page, fixing document title ([\element-hq#6716](matrix-org/matrix-react-sdk#6716)). Fixes element-hq#18668 and element-hq#18668.
* Fix membership updates to Spaces not applying in real-time ([\element-hq#6713](matrix-org/matrix-react-sdk#6713)). Fixes element-hq#18737 and element-hq#18737.
* Don't show a double stacked invite modals when inviting to Spaces ([\element-hq#6698](matrix-org/matrix-react-sdk#6698)). Fixes element-hq#18745 and element-hq#18745. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Remove non-functional DuckDuckGo Autocomplete Provider ([\element-hq#6712](matrix-org/matrix-react-sdk#6712)). Fixes element-hq#18778 and element-hq#18778.
* Filter members on `MemberList` load ([\element-hq#6708](matrix-org/matrix-react-sdk#6708)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix improper voice messages being produced in Firefox and sometimes other browsers. ([\element-hq#6696](matrix-org/matrix-react-sdk#6696)). Fixes element-hq#18587 and element-hq#18587.
* Fix client forgetting which capabilities a widget was approved for ([\element-hq#6685](matrix-org/matrix-react-sdk#6685)). Fixes element-hq#18786 and element-hq#18786.
* Fix left panel widgets not remembering collapsed state ([\element-hq#6687](matrix-org/matrix-react-sdk#6687)). Fixes element-hq#17803 and element-hq#17803.
* Fix changelog link colour back to blue ([\element-hq#6692](matrix-org/matrix-react-sdk#6692)). Fixes element-hq#18726 and element-hq#18726.
* Soften codeblock border color ([\element-hq#6564](matrix-org/matrix-react-sdk#6564)). Fixes element-hq#18367 and element-hq#18367. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Pause ringing more aggressively ([\element-hq#6691](matrix-org/matrix-react-sdk#6691)). Fixes element-hq#18588 and element-hq#18588. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix command autocomplete ([\element-hq#6680](matrix-org/matrix-react-sdk#6680)). Fixes element-hq#18670 and element-hq#18670. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Don't re-sort the room-list based on profile/status changes ([\element-hq#6595](matrix-org/matrix-react-sdk#6595)). Fixes #110 and #110. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix codeblock formatting with syntax highlighting on ([\element-hq#6681](matrix-org/matrix-react-sdk#6681)). Fixes element-hq#18739 element-hq#18365 and element-hq#18739. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Add padding to the Add button in the notification settings ([\element-hq#6665](matrix-org/matrix-react-sdk#6665)). Fixes element-hq#18706 and element-hq#18706. Contributed by [SimonBrandner](https://github.com/SimonBrandner).

Change-Id: I8844e7c1f52e9e42ae9a0d6b1cd0ea6ee5fcf9a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
P1 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@turt2live @ara4n @lampholder @t3chguy @26000