Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click to mention has regressed #6900

Closed
lukebarnard1 opened this issue Jun 18, 2018 · 4 comments
Closed

Click to mention has regressed #6900

lukebarnard1 opened this issue Jun 18, 2018 · 4 comments
Assignees
@lukebarnard1
Labels
A-Pills P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression

Comments

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Jun 18, 2018 •
edited
Loading

Clicking on a SenderProfile (displayname above message) should insert a pill into the composer. This has regressed with an error message (when the composer is empty):

Uncaught TypeError: Cannot read property 'getEntityAt' of undefined
    at Object.removeRange (DraftModifier.js:100)
    at removeTextWithStrategy (removeTextWithStrategy.js:39)
    at keyCommandPlainDelete (keyCommandPlainDelete.js:27)
    at onKeyCommand (editOnKeyDown.js:46)
    at editOnKeyDown (editOnKeyDown.js:141)
    at DraftEditor.react.js:146
...

If the composer has text in it, it appears to insert whitespace but when switching between rich mode and markdown mode, markdown pills might appear. Or the composer might be broken until a room switch happens.
@michaelkaye
Copy link
Contributor

Ah, see also #6899

@lampholder lampholder added T-Defect P1 S-Minor Impairs non-critical functionality or suitable workarounds exist ui/ux labels Jun 18, 2018
@lukebarnard1 lukebarnard1 self-assigned this Jun 18, 2018
@lukebarnard1
Copy link
Contributor Author

lukebarnard1 commented Jun 18, 2018 •
edited
Loading

This is probably because MATRIXTO_URL_PATTERN was changed by https://github.com/matrix-org/matrix-react-sdk/pull/1975/files#diff-43ba768343dac45fa03389f245f80e39R172 and Pill.js depends on that, including positions of groups in the RegExp.

cc. @t3chguy

@lukebarnard1
Copy link
Contributor Author

Having heard the entire office complain, and given I think I know a fix, I'll go and fix this.

@t3chguy
Copy link
Member

t3chguy commented Jun 18, 2018

ah so yeah this is probably my fault with the regex accidentally removing a capturing group when instead I intended to remove the | and replace it with a capturing character group

lukebarnard1 added a commit to matrix-org/matrix-react-sdk that referenced this issue Jun 18, 2018
@lukebarnard1
Fix MATRIXTO_URL_PATTERN RegExp groups
d6f0f77 
Fixes element-hq/element-web#6900
Fixes element-hq/element-web#6899
@lukebarnard1 lukebarnard1 mentioned this issue Jun 18, 2018
Merged
@jryans jryans added the A-Pills label Jun 23, 2020
BBaoVanC added a commit to boba-best/element.boba.best that referenced this issue Oct 11, 2021
@BBaoVanC
Merge tag 'v1.9.1' into build
9fc0278 
* Decrease profile button touch target ([\element-hq#6900](matrix-org/matrix-react-sdk#6900)). Contributed by [ColonisationCaptain](https://github.com/ColonisationCaptain).
* Don't let click events propagate out of context menus ([\element-hq#6892](matrix-org/matrix-react-sdk#6892)).
* Allow closing Dropdown via its chevron ([\element-hq#6885](matrix-org/matrix-react-sdk#6885)). Fixes element-hq#19030 and element-hq#19030.
* Improve AUX panel behaviour ([\element-hq#6699](matrix-org/matrix-react-sdk#6699)). Fixes element-hq#18787 and element-hq#18787. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* A nicer opening animation for the Image View ([\#6454](matrix-org/matrix-react-sdk#6454)). Fixes element-hq#18186 and element-hq#18186. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* [Release] Fix space hierarchy pagination ([\element-hq#6910](matrix-org/matrix-react-sdk#6910)).
* Fix leaving space via other client leaving you in undefined-land ([\element-hq#6891](matrix-org/matrix-react-sdk#6891)). Fixes element-hq#18455 and element-hq#18455.
* Handle newer voice message encrypted event format for chat export ([\element-hq#6893](matrix-org/matrix-react-sdk#6893)). Contributed by [jaiwanth-v](https://github.com/jaiwanth-v).
* Fix pagination when filtering space hierarchy ([\element-hq#6876](matrix-org/matrix-react-sdk#6876)). Fixes element-hq#19235 and element-hq#19235.
* Fix spaces null-guard breaking the dispatcher settings watching ([\element-hq#6886](matrix-org/matrix-react-sdk#6886)). Fixes element-hq#19223 and element-hq#19223.
* Fix space children without specific `order` being sorted after those with one ([\element-hq#6878](matrix-org/matrix-react-sdk#6878)). Fixes element-hq#19192 and element-hq#19192.
* Ensure that sub-spaces aren't considered for notification badges ([\element-hq#6881](matrix-org/matrix-react-sdk#6881)). Fixes element-hq#18975 and element-hq#18975.
* Fix timeline autoscroll with non-standard DPI settings. ([\element-hq#6880](matrix-org/matrix-react-sdk#6880)). Fixes element-hq#18984 and element-hq#18984.
* Pluck out JoinRuleSettings styles so they apply in space settings too ([\element-hq#6879](matrix-org/matrix-react-sdk#6879)). Fixes element-hq#19164 and element-hq#19164.
* Null guard around the matrixClient in SpaceStore ([\element-hq#6874](matrix-org/matrix-react-sdk#6874)).
* Fix issue (https ([\element-hq#6871](matrix-org/matrix-react-sdk#6871)). Fixes element-hq#19138 and element-hq#19138. Contributed by [psrpinto](https://github.com/psrpinto).
* Fix pills being cut off in message bubble layout ([\element-hq#6865](matrix-org/matrix-react-sdk#6865)). Fixes element-hq#18627 and element-hq#18627. Contributed by [robintown](https://github.com/robintown).
* Fix space admin check false positive on multiple admins ([\element-hq#6824](matrix-org/matrix-react-sdk#6824)).
* Fix the User View ([\element-hq#6860](matrix-org/matrix-react-sdk#6860)). Fixes element-hq#19158 and element-hq#19158.
* Fix spacing for message composer buttons ([\element-hq#6852](matrix-org/matrix-react-sdk#6852)). Fixes element-hq#18999 and element-hq#18999.
* Always show root event of a thread in room's timeline ([\element-hq#6842](matrix-org/matrix-react-sdk#6842)). Fixes element-hq#19016 and element-hq#19016.
williamkray added a commit to williamkray/element-web that referenced this issue Nov 9, 2021
@williamkray
Merge tag 'v1.9.1' into develop
c9617bc 
* Decrease profile button touch target ([\element-hq#6900](matrix-org/matrix-react-sdk#6900)). Contributed by [ColonisationCaptain](https://github.com/ColonisationCaptain).
* Don't let click events propagate out of context menus ([\element-hq#6892](matrix-org/matrix-react-sdk#6892)).
* Allow closing Dropdown via its chevron ([\element-hq#6885](matrix-org/matrix-react-sdk#6885)). Fixes element-hq#19030 and element-hq#19030.
* Improve AUX panel behaviour ([\element-hq#6699](matrix-org/matrix-react-sdk#6699)). Fixes element-hq#18787 and element-hq#18787. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* A nicer opening animation for the Image View ([\#6454](matrix-org/matrix-react-sdk#6454)). Fixes element-hq#18186 and element-hq#18186. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* [Release] Fix space hierarchy pagination ([\element-hq#6910](matrix-org/matrix-react-sdk#6910)).
* Fix leaving space via other client leaving you in undefined-land ([\element-hq#6891](matrix-org/matrix-react-sdk#6891)). Fixes element-hq#18455 and element-hq#18455.
* Handle newer voice message encrypted event format for chat export ([\element-hq#6893](matrix-org/matrix-react-sdk#6893)). Contributed by [jaiwanth-v](https://github.com/jaiwanth-v).
* Fix pagination when filtering space hierarchy ([\element-hq#6876](matrix-org/matrix-react-sdk#6876)). Fixes element-hq#19235 and element-hq#19235.
* Fix spaces null-guard breaking the dispatcher settings watching ([\element-hq#6886](matrix-org/matrix-react-sdk#6886)). Fixes element-hq#19223 and element-hq#19223.
* Fix space children without specific `order` being sorted after those with one ([\element-hq#6878](matrix-org/matrix-react-sdk#6878)). Fixes element-hq#19192 and element-hq#19192.
* Ensure that sub-spaces aren't considered for notification badges ([\element-hq#6881](matrix-org/matrix-react-sdk#6881)). Fixes element-hq#18975 and element-hq#18975.
* Fix timeline autoscroll with non-standard DPI settings. ([\element-hq#6880](matrix-org/matrix-react-sdk#6880)). Fixes element-hq#18984 and element-hq#18984.
* Pluck out JoinRuleSettings styles so they apply in space settings too ([\element-hq#6879](matrix-org/matrix-react-sdk#6879)). Fixes element-hq#19164 and element-hq#19164.
* Null guard around the matrixClient in SpaceStore ([\element-hq#6874](matrix-org/matrix-react-sdk#6874)).
* Fix issue (https ([\element-hq#6871](matrix-org/matrix-react-sdk#6871)). Fixes element-hq#19138 and element-hq#19138. Contributed by [psrpinto](https://github.com/psrpinto).
* Fix pills being cut off in message bubble layout ([\element-hq#6865](matrix-org/matrix-react-sdk#6865)). Fixes element-hq#18627 and element-hq#18627. Contributed by [robintown](https://github.com/robintown).
* Fix space admin check false positive on multiple admins ([\element-hq#6824](matrix-org/matrix-react-sdk#6824)).
* Fix the User View ([\element-hq#6860](matrix-org/matrix-react-sdk#6860)). Fixes element-hq#19158 and element-hq#19158.
* Fix spacing for message composer buttons ([\element-hq#6852](matrix-org/matrix-react-sdk#6852)). Fixes element-hq#18999 and element-hq#18999.
* Always show root event of a thread in room's timeline ([\element-hq#6842](matrix-org/matrix-react-sdk#6842)). Fixes element-hq#19016 and element-hq#19016.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukebarnard1 lukebarnard1

Labels
A-Pills P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jryans @michaelkaye @lampholder @t3chguy @lukebarnard1