Images are sometimes sent as files (without preview/thumbnail) when upload speed is slow

[Edszx]

Description

This problem has been there since forever, but i'm finally not being lazy an reporting it properly, when the computer's upload speed is low, say 40KBps for example, sometimes images uploaded to riot are sent as files, meaning, without preview/thumbnail, just a single line of text with the filename that you can click to download, and "X uploaded a file" over it instead of "X sent an image".
I think it happens if there is any packet loss while the image is being uploaded.

Steps to reproduce

• The upload speed has to be terribly low
• Try to send a 1MB image, for example.
• It will take 35+ seconds to upload (again, because for this to happen upload speed has to be low)
• If it doesn't fail/timeout in the process (again, because of the slow upload) it will be sent as a file, without preview and the message "X sent a file" instead of an image.

Log: sent

Screenshots

Version information

• Platform: desktop and web
• Browser: Chrome and Firefox, possibly others.
• OS: Windows
• Version: 0.15.7

[lampholder]

Just recording that I haven't been able to reproduce this yet - Chromes 'Slow 3G' network throttling preset didn't work for a 1.1MB png.

[Edszx]

@lampholder I suggest https://github.com/jagt/clumsy to make your network drop packets, thank you for looking into this.

[t3chguy]

This happens when local thumbnailing fails (and thus riot-web is not sure the file is an image after all)

[Half-Shot]

Ugh, https://github.com/matrix-org/matrix-react-sdk/blob/2dc94ac277bfaed6e7a8116ff08bba22ee8fb642/src/ContentMessages.js#L306

[repli-a]

@t3chguy this also still reliably happens with video files across all browsers (see 1752 , 6426). If this could get a little love it would be a huge benefit to quality of life - multimedia is a big part of how users communicate.

[t3chguy]

I tried this and it came down to a browser/low level library fault
its the browser passing up an error from some C library, I can't remember the specifics

[repli-a]

I remember on our last go-round that it seemed like ffmpeg failing to thumbnail was the cause. But it was doing it on dirt-common h264 stuff that it should be able to do in its sleep. This now seems like yet another different but similar issue (since it's an image I'm guessing imagemagick is doing the thumbnailing)?

Two different types of media processed by two different programs having the same issue coupled with the fact that it happens on all versions and browsers suggests to me a fault with Riot itself. Forgive the input from the peanut gallery here, but from the outside looking in it seems like the error handling for this process isn't tolerant enough of minor hitches, hangups, and latency and instead just throws its hands up and labels the media m.file if it hits any snags along the way, however momentary.

[sevmonster]

Is this still an issue? I have users that are uploading videos and they are saved as m.file events rather than m.video. I don't know if it's related to this issue, but all the other "my video won't play" issues that I can find were closed as duplicates of this one. It's not #6426 either (if that is still an issue), as the video in question was a 3MB webm.

[SamiLehtinen]

I were one of users suffering from this problem way too often. Haven't seen the problem for a good while. Yet I also switched to much faster server. But based on my experience, I could assume it's not a practical problem anymore. Of course test cases should cover the situations where post fails. If that's done, then this is also technically fixed.

[ara4n]

Just got bitten by this yet again, while on poor wifi. Have rageshaked on it.