Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prune any unused images #8158

Closed
jryans opened this issue Jan 18, 2019 · 2 comments
Closed

Prune any unused images #8158

jryans opened this issue Jan 18, 2019 · 2 comments
Assignees
@jryans
Labels
P2 T-Task Tasks for the team like planning

Comments

@jryans
Copy link
Collaborator

jryans commented Jan 18, 2019 •
edited
Loading

No description provided.

@jryans
Copy link
Collaborator Author

jryans commented Jan 18, 2019

Once we have a build process for images (the likely outcome of #7932), it will be quite easy to see which images are unreferenced and can be removed.

@lampholder lampholder added T-Task Tasks for the team like planning P2 labels Jan 21, 2019
@jryans jryans self-assigned this Feb 20, 2019
jryans added a commit to jryans/matrix-react-sdk that referenced this issue Feb 20, 2019
@jryans
Remove unreferenced images
aeae007 
Now that images flow through a build step, it's easy to spot where aren't
actually used. To determine this, I built Riot with the hash in file names
disabled, and then used a directory compare tool to look for all images in the
SDK that did not make into the Riot build.

Fixes element-hq/element-web#8158
jryans added a commit to jryans/matrix-react-sdk that referenced this issue Feb 20, 2019
@jryans
Remove unreferenced images
1594bcf 
Now that images flow through a build step, it's easy to spot where aren't
actually used. To determine this, I built Riot with the hash in file names
disabled, and then used a directory compare tool to look for all images in the
SDK that did not make it into the Riot build.

Fixes element-hq/element-web#8158
jryans added a commit to jryans/matrix-react-sdk that referenced this issue Feb 20, 2019
@jryans
Remove unreferenced images
567280a 
Now that images flow through a build step, it's easy to spot which ones aren't
actually used. To determine this, I built Riot with the hash in file names
disabled, and then used a directory compare tool to look for all images in the
SDK that did not make it into the Riot build.

Fixes element-hq/element-web#8158
@jryans jryans mentioned this issue Feb 20, 2019
Merged
@jryans
Copy link
Collaborator Author

jryans commented Feb 20, 2019

Fixed by matrix-org/matrix-react-sdk#2670

@jryans jryans closed this as completed Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
P2 T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jryans @lampholder