Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newly created rooms don't show up in the room list #8868

Closed
turt2live opened this issue Feb 21, 2019 · 2 comments · Fixed by matrix-org/matrix-react-sdk#2681
Closed

Newly created rooms don't show up in the room list #8868

turt2live opened this issue Feb 21, 2019 · 2 comments · Fixed by matrix-org/matrix-react-sdk#2681
Assignees
@turt2live
Labels
A-Room-List P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@turt2live
Copy link
Member

Probably a bug in the new algo
@turt2live turt2live self-assigned this Feb 21, 2019
@turt2live
Copy link
Member Author

Also applies to invites, and joins

@turt2live turt2live added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Room-List defect P1 labels Feb 22, 2019
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Feb 22, 2019
@turt2live
Fix categorization of favourites and new rooms
e7b3cbf 
New rooms (joined, invited, created, etc) were being ignored because they matched the check as soon as the iterator hit a non-recents section. This fixes the check to ensure there's a positive ID on the room being in the tag (or not, in the case of new rooms) before lying to the rest of the function.

Additionally, a fix for favourites has been included to stop the list expanding to fill the void - turns out it was inserting the room twice into the list, and this was breaking the tile rendering. The room sublist would allocate space for the tile, but React would prevent the tile from showing up because of duplicate keys.

Fixes element-hq/element-web#8868
Fixes element-hq/element-web#8857 correctly
@turt2live turt2live mentioned this issue Feb 22, 2019
Merged
@turt2live
Copy link
Member Author

Fixed by matrix-org/matrix-react-sdk#2681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Room-List P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix categorization of favourites and new rooms matrix-org/matrix-react-sdk
1 participant
@turt2live