Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replies prepend replied-to message to reply text in timeline #8969

Closed
bwindels opened this issue Feb 27, 2019 · 8 comments
Closed

Replies prepend replied-to message to reply text in timeline #8969

bwindels opened this issue Feb 27, 2019 · 8 comments
Labels
P2

Comments

@bwindels
Copy link
Contributor

bwindels commented Feb 27, 2019 •
edited
Loading

image
@bwindels bwindels added the P1 label Feb 27, 2019
@bwindels
Copy link
Contributor Author

reply was "test" from Amandine, but Hubert's message got prepended to it on the same line.

@t3chguy
Copy link
Member

t3chguy commented Feb 27, 2019

Could you show what the event looks like? Is this a sending or rendering issue...?

@bwindels
Copy link
Contributor Author

Looking into it... m.relates_to seems to be missing from the reply, sent with Riot Android...

@bwindels
Copy link
Contributor Author

bwindels commented Feb 27, 2019 •
edited
Loading

source for the original event:

{
  "content": {
    "body": "> <@Amandine:matrix.org> Do we have more updates on the crypto issues or was uhoreg too lost in cross signing yesterday?\n\nI got a bit distracted by cross-signing stuff yesterday, but I'm still working on the crypto issues.",
    "format": "org.matrix.custom.html",
    "formatted_body": "<mx-reply><blockquote><a href=\"https://matrix.to/#/<redacted room id>/<redacted event id>\">In reply to</a> <a href=\"https://matrix.to/#/@Amandine:matrix.org\">@Amandine:matrix.org</a><br>Do we have more updates on the crypto issues or was <a href=\"https://matrix.to/#/@uhoreg:matrix.org\">uhoreg</a> too lost in cross signing yesterday?</blockquote></mx-reply>I got a bit distracted by cross-signing stuff yesterday, but I'm still working on the crypto issues.",
    "msgtype": "m.text"
  },
  "room_id": "<redacted room id>",
  "type": "m.room.message"
}

@bwindels
Copy link
Contributor Author

riot web should probably not include the mx-reply to this, but as m.relates_to should be there normally, demoting this to p2.

@bwindels bwindels added P2 and removed P1 labels Feb 27, 2019
@bwindels
Copy link
Contributor Author

fwiw, these changes to ReplyThread.js got merged this monday, but don't seem related AFAICT:

https://github.com/matrix-org/matrix-react-sdk/pull/2671/files#diff-b9d18900308f768e1b0937cb16dcdb28L88

@bwindels bwindels changed the title replys prepend replied-to message to reply text in timeline Replies prepend replied-to message to reply text in timeline Feb 27, 2019
@tuxayo
Copy link
Contributor

tuxayo commented Mar 4, 2019

Here is an instance of the issue, if that can help
https://matrix.to/#/!UCnwUWwIKhcpaPTHtR:sw1v.org/$15517103872018981RPVip:matrix.org?via=sw1v.org&via=matrix.org&via=chat.weho.st

riot-web: 1.0.1
Riot android: probably the latest from Play store

@bwindels bwindels mentioned this issue Mar 5, 2019
Open
@uhoreg
Copy link
Member

uhoreg commented Jul 16, 2020

fixed by matrix-org/matrix-react-sdk#5006

@uhoreg uhoreg closed this as completed Jul 16, 2020
su-ex added a commit to SchildiChat/element-web that referenced this issue Jan 15, 2023
@su-ex
Merge tag 'v1.11.17' into sc
eac9806 
* Add inline code formatting to rich text editor ([\element-hq#9720](matrix-org/matrix-react-sdk#9720)).
* Add emoji handling for plain text mode of the new rich text editor ([\element-hq#9727](matrix-org/matrix-react-sdk#9727)).
* Overlay virtual room call events into main timeline ([\element-hq#9626](matrix-org/matrix-react-sdk#9626)). Fixes element-hq#22929.
* Adds a new section under "Room Settings" > "Roles & Permissions" which adds the possibility to multiselect users from this room and grant them more permissions. ([\element-hq#9596](matrix-org/matrix-react-sdk#9596)). Contributed by @GoodGuyMarco.
* Add emoji handling for rich text mode ([\element-hq#9661](matrix-org/matrix-react-sdk#9661)).
* Add setting to hide bold notifications ([\element-hq#9705](matrix-org/matrix-react-sdk#9705)).
* Further password reset flow enhancements ([\element-hq#9662](matrix-org/matrix-react-sdk#9662)).
* Snooze the bulk unverified sessions reminder on dismiss ([\element-hq#9706](matrix-org/matrix-react-sdk#9706)).
* Honor advanced audio processing settings when recording voice messages ([\element-hq#9610](matrix-org/matrix-react-sdk#9610)). Contributed by @MrAnno.
* Improve the visual balance of bubble layout ([\element-hq#9704](matrix-org/matrix-react-sdk#9704)).
* Add config setting to disable bulk unverified sessions nag ([\element-hq#9657](matrix-org/matrix-react-sdk#9657)).
* Only display bulk unverified sessions nag when current sessions is verified ([\element-hq#9656](matrix-org/matrix-react-sdk#9656)).
* Separate labs and betas more clearly ([\element-hq#8969](matrix-org/matrix-react-sdk#8969)). Fixes element-hq#22706.
* Show user an error if we fail to create a DM for verification. ([\element-hq#9624](matrix-org/matrix-react-sdk#9624)).
* Prevent unnecessary m.direct updates ([\element-hq#9805](matrix-org/matrix-react-sdk#9805)). Fixes element-hq#24059.
* Fix checkForPreJoinUISI for thread roots ([\element-hq#9803](matrix-org/matrix-react-sdk#9803)). Fixes element-hq#24054.
* Load RTE components only when RTE labs is enabled ([\element-hq#9804](matrix-org/matrix-react-sdk#9804)).
* Fix issue where thread panel did not update correctly ([\element-hq#9746](matrix-org/matrix-react-sdk#9746)). Fixes element-hq#23971.
* Remove async call to get virtual room from room load ([\element-hq#9743](matrix-org/matrix-react-sdk#9743)). Fixes element-hq#23968.
* Check each thread for unread messages. ([\element-hq#9723](matrix-org/matrix-react-sdk#9723)).
* Device manage - handle sessions that don't support encryption ([\element-hq#9717](matrix-org/matrix-react-sdk#9717)). Fixes element-hq#23722.
* Fix hover state for formatting buttons (Rich text editor) (fix element-hq/issues/23832) ([\element-hq#9715](matrix-org/matrix-react-sdk#9715)).
* Don't allow group calls to be unterminated ([\element-hq#9710](matrix-org/matrix-react-sdk#9710)).
* Fix replies to emotes not showing as inline ([\element-hq#9707](matrix-org/matrix-react-sdk#9707)). Fixes element-hq#23903.
* Update copy of 'Change layout' button to match Element Call ([\element-hq#9703](matrix-org/matrix-react-sdk#9703)).
* Fix call splitbrains when switching between rooms ([\element-hq#9692](matrix-org/matrix-react-sdk#9692)).
* bugfix: fix an issue where the Notifier would incorrectly fire for non-timeline events ([\element-hq#9664](matrix-org/matrix-react-sdk#9664)). Fixes element-hq#17263.
* Fix power selector being wrongly disabled for admins themselves ([\element-hq#9681](matrix-org/matrix-react-sdk#9681)). Fixes element-hq#23882.
* Show day counts in call durations ([\element-hq#9641](matrix-org/matrix-react-sdk#9641)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bwindels @uhoreg @t3chguy @tuxayo