Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share Message in right-click message gives broken link #9110

Closed
anoadragon453 opened this issue Mar 11, 2019 · 6 comments
Closed

Share Message in right-click message gives broken link #9110

anoadragon453 opened this issue Mar 11, 2019 · 6 comments
Assignees
@jryans
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression

Comments

@anoadragon453
Copy link
Member

anoadragon453 commented Mar 11, 2019 •
edited
Loading

Right-click on a message and (don't click, but) right-click "Share Message" and copy. You'll get a link that looks like:

https://matrix.to/#/!QtykxKocfZaZOUrTwp:matrix.org/!QtykxKocfZaZOUrTwp:matrix.org

The format of the link should be https://matrix.to/#/<room ID>/<event ID> but it is instead https://matrix.to/#/<room ID>/<room ID>.

Seems like a fairly high priority bug.

Version information

  • Platform: web
  • Browser: Chrome
  • OS: Debian Linux
  • URL: independent build of riot.im/develop
@jryans
Copy link
Collaborator

jryans commented Mar 11, 2019

https://riot.im/develop appears to produce the correct URL with room and event as expected. Are there any other steps? What do you see if you try https://riot.im/develop?

@anoadragon453
Copy link
Member Author

Yep, same bug in riot.im/develop

@jryans
Copy link
Collaborator

jryans commented Mar 11, 2019

Perhaps the particular message you are trying to share is relevant? Could you describe a room and message I can find through other means that exhibits this issue?

@anoadragon453
Copy link
Member Author

Any message is Matrix HQ is doing it for me.

@anoadragon453
Copy link
Member Author

Ah I think I see the issue. I'm not clicking Share Message, I'm right-clicking it in the menu and copying it. It's fine in the actual modal view that pops up but not in the message right-click menu.

@jryans
Copy link
Collaborator

jryans commented Mar 11, 2019

Aha, yes, I agree, the link on the "Share Message" item itself is broken.

@jryans jryans added T-Defect P1 X-Regression S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Mar 11, 2019
@jryans jryans self-assigned this Mar 11, 2019
jryans added a commit to jryans/matrix-react-sdk that referenced this issue Mar 11, 2019
@jryans
Pass correct args when creating event permalink in context menu
c38a7e6 
After the permalink API was changed in
matrix-org#2671, it seems we forgot to
update this call site, so it was creating `<room>/<room>` links, instead of
`<room>/<event>`.

Fixes element-hq/element-web#9110
@jryans jryans mentioned this issue Mar 11, 2019
Merged
krombel pushed a commit to krombel/matrix-react-sdk that referenced this issue Mar 15, 2019
@jryans @krombel
Pass correct args when creating event permalink in context menu
a34e512 
After the permalink API was changed in
matrix-org#2671, it seems we forgot to
update this call site, so it was creating `<room>/<room>` links, instead of
`<room>/<event>`.

Fixes element-hq/element-web#9110
su-ex added a commit to SchildiChat/element-web that referenced this issue Aug 22, 2022
@su-ex
Merge tag 'v1.11.3' into sc
d397360 
* Improve auth aria attributes and semantics ([\element-hq#22948](element-hq#22948)).
* Device manager - New device tile info design ([\element-hq#9122](matrix-org/matrix-react-sdk#9122)). Contributed by @kerryarchibald.
* Device manager generic settings subsection component ([\element-hq#9147](matrix-org/matrix-react-sdk#9147)). Contributed by @kerryarchibald.
* Migrate the hidden read receipts flag to new "send read receipts" option ([\element-hq#9141](matrix-org/matrix-react-sdk#9141)).
* Live location sharing - share location at most every 5 seconds ([\element-hq#9148](matrix-org/matrix-react-sdk#9148)). Contributed by @kerryarchibald.
* Increase max length of voice messages to 15m ([\element-hq#9133](matrix-org/matrix-react-sdk#9133)). Fixes element-hq#18620.
* Move pin drop out of labs ([\element-hq#9135](matrix-org/matrix-react-sdk#9135)).
* Start DM on first message ([\element-hq#8612](matrix-org/matrix-react-sdk#8612)). Fixes element-hq#14736.
* Remove "Add Space" button from RoomListHeader when user cannot create spaces ([\element-hq#9129](matrix-org/matrix-react-sdk#9129)).
* The Welcome Home Screen: Dedicated Download Apps Dialog ([\element-hq#9120](matrix-org/matrix-react-sdk#9120)). Fixes element-hq#22921. Contributed by @justjanne.
* The Welcome Home Screen: "Submit Feedback" pane ([\element-hq#9090](matrix-org/matrix-react-sdk#9090)). Fixes element-hq#22918. Contributed by @justjanne.
* New User Onboarding Task List ([\element-hq#9083](matrix-org/matrix-react-sdk#9083)). Fixes element-hq#22919. Contributed by @justjanne.
* Add support for disabling spell checking ([\element-hq#8604](matrix-org/matrix-react-sdk#8604)). Fixes element-hq#21901.
* Live location share - leave maximised map open when beacons expire ([\element-hq#9098](matrix-org/matrix-react-sdk#9098)). Contributed by @kerryarchibald.
* Some slash-commands (`/myroomnick`) have temporarily been disabled before the first message in a DM is sent. ([\element-hq#9193](matrix-org/matrix-react-sdk#9193)).
* Use stable reference for active tab in tabbedView ([\#9145](matrix-org/matrix-react-sdk#9145)). Contributed by @kerryarchibald.
* Fix pillification sometimes doubling up ([\element-hq#9152](matrix-org/matrix-react-sdk#9152)). Fixes element-hq#23036.
* Fix highlights not being applied to plaintext messages ([\element-hq#9126](matrix-org/matrix-react-sdk#9126)). Fixes element-hq#22787.
* Fix dismissing edit composer when change was undone ([\element-hq#9109](matrix-org/matrix-react-sdk#9109)). Fixes element-hq#22932.
* 1-to-1 DM rooms with bots now act like DM rooms instead of multi-user-rooms before ([\element-hq#9124](matrix-org/matrix-react-sdk#9124)). Fixes element-hq#22894.
* Apply inline start padding to selected lines on modern layout only ([\element-hq#9006](matrix-org/matrix-react-sdk#9006)). Fixes element-hq#22768. Contributed by @luixxiul.
* Peek into world-readable rooms from spotlight ([\element-hq#9115](matrix-org/matrix-react-sdk#9115)). Fixes element-hq#22862.
* Use default styling on nested numbered lists due to MD being sensitive ([\element-hq#9110](matrix-org/matrix-react-sdk#9110)). Fixes element-hq#22935.
* Fix replying using chat effect commands ([\element-hq#9101](matrix-org/matrix-react-sdk#9101)). Fixes element-hq#22824.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jryans @anoadragon453