Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't use Numpad keys (+, -, 0) to control zoom #9533

Closed
dogancelik opened this issue Apr 20, 2019 · 11 comments
Closed

Can't use Numpad keys (+, -, 0) to control zoom #9533

dogancelik opened this issue Apr 20, 2019 · 11 comments
Labels
A-Shortcuts Keyboard shortcuts P2 T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter

Comments

@dogancelik
Copy link

dogancelik commented Apr 20, 2019 •
edited
Loading

Turkish keyboard layout

This is the keyboard layout used in Turkey.

0 * - (without SHIFT key)
= ? _ (with SHIFT key)
  • Turkish keyboard doesn't have minus and plus like in US keyboard.
  • Turkish users can't use Zoom In (no PLUS key), we use Numpad to control zoom on all browsers.
  • All browsers (e.g. Chrome, Firefox) support Numpad keys.
  • Numpad section on Turkish keyboard has - + 0 but it doesn't work on Riot Web.

Numpad

Numpad

View Menu

View Menu

Version information

  • OS: Windows 10 (64-bit)
  • Version: Riot Web Desktop client 1.0.8
@lampholder
Copy link
Member

Would #3160 solve the problem?

@lampholder lampholder added the X-Needs-Info This issue is blocked awaiting information from the reporter label Apr 24, 2019
@dogancelik
Copy link
Author

@lampholder Yes. Still, fixing keyboard shortcuts would be a plus.

@ordinarygulp ordinarygulp mentioned this issue May 3, 2019
Closed
@aaronraimist
Copy link
Collaborator

aaronraimist commented May 3, 2019 •
edited
Loading

Ugh sorry #8381 probably broke this. Good news is Electron did implement my feature request to allow hidden items to keep working but it is only available starting in Electron 6.0.0.beta.1 but Riot is using 4.1.3 so we can't use that yet. @jryans I guess we should put back the other menu item?

electron/electron#16853

would be a plus.

😄

@jryans
Copy link
Collaborator

jryans commented May 7, 2019

@jryans I guess we should put back the other menu item?

Bluh, yes I suppose so. 😭 (I am just sad that Electron makes this so hard...)

@aaronraimist aaronraimist mentioned this issue May 9, 2019
Closed
@aaronraimist
Copy link
Collaborator

Numpad section on Turkish keyboard has - + 0 but it doesn't work on Riot Web.

First I read this issue as just zoom in (+/=) didn't work but @dogancelik are you saying zoom out (-) and reset zoom (0) don't work either?

I put back the default electron zoom in menu item in #9654 which should fix the zoom in at least but if the other ones don't work then I don't know what the problem is.

@dogancelik
Copy link
Author

dogancelik commented May 12, 2019 •
edited
Loading

@aaronraimist

works-doesnt-work

For accessibility:

  • 0 and - keys above QWERTY row works.
  • 0, - and + keys on Numpad does NOT work.

@aaronraimist
Copy link
Collaborator

Alright :( I don’t know what the problem is then.

On my US English keyboard the numpad keys do work.

@jryans jryans added the A-Shortcuts Keyboard shortcuts label Feb 5, 2020
@jryans jryans removed the Z-UI/UX label Mar 9, 2021
@t3chguy t3chguy mentioned this issue Apr 29, 2021
Closed
@aaronraimist aaronraimist mentioned this issue Jun 4, 2021
Merged
@aaronraimist
Copy link
Collaborator

@dogancelik element-hq/element-desktop#202 may have fixed this. You can try Element Nightly and see if it works now. https://packages.riot.im/nightly/install/

@t3chguy
Copy link
Member

t3chguy commented Jun 4, 2021

It has for me on macos + USB keyboard, shout if still broken for you.

@t3chguy t3chguy closed this as completed Jun 4, 2021
@dogancelik
Copy link
Author

dogancelik commented Jun 4, 2021 •
edited
Loading

I downloaded the nightly, it has the same key bindings as before. Even though it shows Ctrl + -, Ctrl + 0, they don't work in TR keyboard layout. If I switch to US kb. layout then it works (I mean not numpad keys but the normal ones).
zoom crop

Here's what it looks like when I use the numpad keys.
zoom working

This is not a problem of Element but of Electron. I found a solution here and will submit a PR to element-desktop if you agree.

@aaronraimist
Copy link
Collaborator

If that fixes it for you then sure.

@dogancelik dogancelik mentioned this issue Jun 4, 2021
Merged
su-ex added a commit to SchildiChat/element-web that referenced this issue Nov 25, 2022
@su-ex
Merge tag 'v1.11.15' into sc
887be88 
* Make clear notifications work with threads ([\element-hq#9575](matrix-org/matrix-react-sdk#9575)). Fixes element-hq#23751.
* Change "None" to "Off" in notification options ([\element-hq#9539](matrix-org/matrix-react-sdk#9539)). Contributed by @Arnei.
* Advanced audio processing settings ([\element-hq#8759](matrix-org/matrix-react-sdk#8759)). Fixes element-hq#6278. Contributed by @MrAnno.
* Add way to create a user notice via config.json ([\element-hq#9559](matrix-org/matrix-react-sdk#9559)).
* Improve design of the rich text editor ([\element-hq#9533](matrix-org/matrix-react-sdk#9533)). Contributed by @florianduros.
* Enable user to zoom beyond image size ([\element-hq#5949](matrix-org/matrix-react-sdk#5949)). Contributed by @jaiwanth-v.
* Fix: Move "Leave Space" option to the bottom of space context menu ([\element-hq#9535](matrix-org/matrix-react-sdk#9535)). Contributed by @hanadi92.
* Make build scripts work on NixOS ([\element-hq#23740](element-hq#23740)).
* Fix integration manager `get_open_id_token` action and add E2E tests ([\element-hq#9520](matrix-org/matrix-react-sdk#9520)).
* Fix links being mangled by markdown processing ([\element-hq#9570](matrix-org/matrix-react-sdk#9570)). Fixes element-hq#23743.
* Fix: inline links selecting radio button ([\element-hq#9543](matrix-org/matrix-react-sdk#9543)). Contributed by @hanadi92.
* Fix wrong error message in registration when phone number threepid is in use. ([\element-hq#9571](matrix-org/matrix-react-sdk#9571)). Contributed by @bagvand.
* Fix missing avatar for show current profiles ([\element-hq#9563](matrix-org/matrix-react-sdk#9563)). Fixes element-hq#23733.
* Fix read receipts trickling down correctly ([\element-hq#9567](matrix-org/matrix-react-sdk#9567)). Fixes element-hq#23746.
* Resilience fix for homeserver without thread notification support ([\element-hq#9565](matrix-org/matrix-react-sdk#9565)).
* Don't switch to the home page needlessly after leaving a room ([\element-hq#9477](matrix-org/matrix-react-sdk#9477)).
* Differentiate download and decryption errors when showing images ([\element-hq#9562](matrix-org/matrix-react-sdk#9562)). Fixes element-hq#3892.
* Close context menu when a modal is opened to prevent user getting stuck ([\element-hq#9560](matrix-org/matrix-react-sdk#9560)). Fixes element-hq#15610 and element-hq#10781.
* Fix TimelineReset handling when no room associated ([\element-hq#9553](matrix-org/matrix-react-sdk#9553)).
* Always use current profile on thread events ([\#9524](matrix-org/matrix-react-sdk#9524)). Fixes element-hq#23648.
* Fix `ThreadView` tests not using thread flag ([\element-hq#9547](matrix-org/matrix-react-sdk#9547)). Contributed by @MadLittleMods.
* Handle deletion of `m.call` events ([\element-hq#9540](matrix-org/matrix-react-sdk#9540)). Fixes element-hq#23663.
* Fix incorrect notification count after leaving a room with notifications ([\element-hq#9518](matrix-org/matrix-react-sdk#9518)). Contributed by @Arnei.
@MrPotatoLord MrPotatoLord mentioned this issue Dec 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Shortcuts Keyboard shortcuts P2 T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jryans @dogancelik @lampholder @t3chguy @aaronraimist