Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix webpack to babel js-sdk & react-sdk but no other deps #11944

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Fix webpack to babel js-sdk & react-sdk but no other deps #11944

merged 1 commit into from
Jan 20, 2020

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Jan 20, 2020

This was happening implicitly in our dev setups and the CI build
because of the comment on the last line.

@dbkr
Fix webpack to babel js-sdk & react-sdk but no other deps
922ed59 
This was happening implicitly in our dev setups and the CI build
because of the comment on the last line.
@dbkr dbkr requested a review from a team January 20, 2020 16:56
turt2live
turt2live approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better than awkward regex.

@dbkr dbkr merged commit 4c699d8 into develop Jan 20, 2020
@dbkr dbkr mentioned this pull request Jan 20, 2020
Merged
@t3chguy t3chguy deleted the dbkr/fix_build_webpack branch May 12, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbkr @turt2live