Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix webpack config (by stealing Dave's config) #11994

Merged
merged 4 commits into from
Jan 22, 2020
Merged

Fix webpack config (by stealing Dave's config) #11994

merged 4 commits into from
Jan 22, 2020

Commits on Jan 22, 2020

  1. Fix build to not babel modules inside js/react sdk 

    Adds 'src' to react-sdk & js-sdk babel test path so we don't run node
modules inside js & react sdk through babel
    @dbkr
    dbkr committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    2e2e09e View commit details
    Browse the repository at this point in the history

  2. Third try at fixing build

    @dbkr
    dbkr committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    c197c2f View commit details
    Browse the repository at this point in the history

  3. Fix webpack config (by stealing Dave's config) 

    Without doing something like this it's hard to use `yarn link`ed resources.
    @turt2live @dbkr
    turt2live authored and dbkr committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    8c103b5 View commit details
    Browse the repository at this point in the history

  4. path.resolve does joining too so path.join is redundant

    @dbkr
    dbkr committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    d4e4610 View commit details
    Browse the repository at this point in the history