Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document feature_spaces_metaspaces #19679

Merged
merged 5 commits into from
Nov 11, 2021
Merged

Document feature_spaces_metaspaces #19679

merged 5 commits into from
Nov 11, 2021

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Nov 10, 2021


This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Tasks for the team like planning label Nov 10, 2021
@t3chguy t3chguy marked this pull request as ready for review November 10, 2021 11:33
@t3chguy t3chguy requested a review from a team as a code owner November 10, 2021 11:33
docs/labs.md Outdated Show resolved Hide resolved
Co-authored-by: Jonathan de Jong <jonathandejong02@gmail.com>
@@ -56,5 +56,8 @@
"posthog": {
"projectApiKey": "phc_Jzsm6DTm6V2705zeU5dcNvQDlonOR68XvX2sh1sEOHO",
"apiHost": "https://posthog.hss.element.io"
},
"features": {
"feature_spaces_metaspaces": true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will force it on with no UI path to disable, so we may want to be sure that is okay.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussion it is okay for this specific lab, but we will need a way to have default-on labs via config.json without them being forced-on for IA1.3 and IA1.5

@t3chguy t3chguy merged commit 8e58d31 into develop Nov 11, 2021
@t3chguy t3chguy deleted the t3chguy/fix/19529 branch November 11, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants