Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wmwragg/chat multi invite #2181

Merged
merged 13 commits into from
Sep 13, 2016
Merged

Wmwragg/chat multi invite #2181

merged 13 commits into from
Sep 13, 2016

Conversation

wmwragg
Copy link
Contributor

@wmwragg wmwragg commented Sep 13, 2016

This should close #2131 and some of #1758 . A companion branch matrix-org/matrix-react-sdk:wmwragg/chat-multi-invite also needs to be merged.

Signed-off-by: William Wragg wm.wragg@gmail.com

@matrixbot
Copy link

Can one of the admins verify this patch?

@ara4n
Copy link
Member

ara4n commented Sep 13, 2016

  • the overflow scrollbar on the RHS of the input field seems to be stuck on?
  • ...likewise on the autocomplete selection
  • the padding of the autocomplete doesn't match the design (compare the height of 3 rows between @antikewl's zeplin design and the implementation)
  • the autocomplete doesn't take up the full width (but this may be deliberate?
  • the entirety of the invite tile should probably be a hit target
  • it would be really nice if tab completed manual mxids (as well as space and comma), given tab-complete is our common idiom here.

Otherwise this is looking really good! Unsure whether to merge now and apply the cosmetic tweaks after the event or wait for this before cutting the freeze...

@ara4n
Copy link
Member

ara4n commented Sep 13, 2016

Final question: is a deliberate design that the 'User ID, Name or email' prompt is always on the last line, rather than flowing inline and moving over the autocomplete bar to match? (superficially, removing the width of the textarea, setting display: inline-block and putting a relative offset on the autocomplete bar seems to work)

@ara4n ara4n merged commit c6a9614 into develop Sep 13, 2016
@ara4n
Copy link
Member

ara4n commented Sep 13, 2016

(merged, although the stuff above still needs to be addressed somewhere)

@ara4n
Copy link
Member

ara4n commented Sep 14, 2016

moving the feedback to #1882 so it's not lost.

@ara4n ara4n mentioned this pull request Sep 14, 2016
3 tasks
@t3chguy t3chguy deleted the wmwragg/chat-multi-invite branch May 12, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support starting a chat with multiple people on the 'find people' page
3 participants