Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the registration page scrollable for small screens #23771

Closed
wants to merge 1 commit into from
Closed

Make the registration page scrollable for small screens #23771

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vector/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
</head>
<body style="height: 100%; margin: 0;">
<noscript>Sorry, Element requires JavaScript to be enabled.</noscript> <!-- TODO: Translate this? -->
<section id="matrixchat" style="height: 100%;" class="notranslate"></section>
<section id="matrixchat" style="height: 100%; overflow-y: auto" class="notranslate"></section>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't be applying any rules here beyond what is necessary, especially as whole-page scrolling for what is nominally a full screen app is a bad time. The rule should be applied to the smallest effect needed, in the very components it affects. This will likely also break overscroll bounce on OSX and iOS as per the comment in the style file. Such a change could also really benefit from Percy testing.

image

<script src="<%= htmlWebpackPlugin.files.js.find(entry => entry.includes("bundle.js")) %>"></script>

<!-- Legacy supporting Prefetch images -->
Expand Down