Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace newTranslatableError with UserFriendlyError #25002

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

justjanne
Copy link
Contributor

@justjanne justjanne commented Mar 31, 2023

Type: Task
Related: matrix-org/matrix-react-sdk#10440

Fixes the current build failures due to the changed API (follow-up to matrix-org/matrix-react-sdk#10440)


This change is marked as an internal change (Task), so will not be included in the changelog.

@justjanne justjanne added the T-Task Tasks for the team like planning label Mar 31, 2023
@justjanne justjanne force-pushed the justjanne/fix/user-friendly-error branch from 4999136 to 43914ff Compare March 31, 2023 09:52
@justjanne justjanne marked this pull request as ready for review March 31, 2023 10:05
@justjanne justjanne requested review from a team as code owners March 31, 2023 10:05
@justjanne justjanne merged commit 89054a5 into develop Mar 31, 2023
@justjanne justjanne deleted the justjanne/fix/user-friendly-error branch March 31, 2023 10:41
@MadLittleMods
Copy link
Contributor

Thank you @justjanne for noticing this downstream usage and fixing our builds 🦞

@MadLittleMods MadLittleMods changed the title Replace newTranslatableError with UserFriendlyError Replace newTranslatableError with UserFriendlyError Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants