Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make auto-update configureable #2555

Merged
merged 2 commits into from
Nov 8, 2016
Merged

Make auto-update configureable #2555

merged 2 commits into from
Nov 8, 2016

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Nov 8, 2016

Otherwise everyone that builds electron vector will end up with
their apps auto-updatin to our version when we release an update.

Coming next: A way to manage our electron release process to make
sure we never ship a build with auto-update disabled.

Otherwise everyone that builds electron vector will end up with
their apps auto-updatin to our version when we release an update.

Coming next: A way to manage our electron release process to make
sure we never ship a build with auto-update disabled.
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

try {
vectorConfig = require('../../vector/config.json');
} catch (e) {
console.log(`file://${__dirname}/../../vector/config.json`, e);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably needs more words

@richvdh richvdh assigned dbkr and unassigned richvdh Nov 8, 2016
@dbkr dbkr merged commit ccc43cc into develop Nov 8, 2016
@dbkr dbkr deleted the dbkr/auto_update_config branch December 14, 2016 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants