Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate welcome bot welcome_user_id support #26885

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jan 17, 2024

It is untested, quite limited, and largely unsupported. Will be removed in an upcoming version.


Here's what your changelog entry will look like:

🦖 Deprecations

  • Deprecate welcome bot welcome_user_id support (#26885).

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy added the T-Deprecation A pull request that makes something deprecated label Jan 17, 2024
@t3chguy t3chguy requested a review from a team as a code owner January 17, 2024 10:23
@t3chguy t3chguy self-assigned this Jan 17, 2024
@t3chguy t3chguy added this pull request to the merge queue Jan 17, 2024
Merged via the queue into develop with commit a410f96 Jan 17, 2024
32 checks passed
@t3chguy t3chguy deleted the t3chguy/kill-welcome_user_id branch January 17, 2024 11:36
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Feb 3, 2024
Weirdly, there is no 1.11.56, so it apparently was skipped?

Changes in [1.11.57](https://github.com/element-hq/element-web/releases/tag/v1.11.57) (2024-01-31)
==================================================================================================
## 🦖 Deprecations

* Deprecate welcome bot `welcome_user_id` support ([#26885](element-hq/element-web#26885)). Contributed by @t3chguy.

## ✨ Features

* Expose apps/widgets ([#12071](matrix-org/matrix-react-sdk#12071)). Contributed by @charlynguyen.
* Enable the rust-crypto labs button ([#12114](matrix-org/matrix-react-sdk#12114)). Contributed by @richvdh.
* Show a progress bar while migrating from legacy crypto ([#12104](matrix-org/matrix-react-sdk#12104)). Contributed by @richvdh.
* Update Twemoji to Jdecked v15.0.3 ([#12147](matrix-org/matrix-react-sdk#12147)). Contributed by @t3chguy.
* Change Quick Settings icon ([#12141](matrix-org/matrix-react-sdk#12141)). Contributed by @florianduros.
* Use Compound tooltips more widely ([#12128](matrix-org/matrix-react-sdk#12128)). Contributed by @t3chguy.

## 🐛 Bug Fixes

* Fix OIDC bugs due to amnesiac stores forgetting OIDC issuer \& other data ([#12166](matrix-org/matrix-react-sdk#12166)). Contributed by @t3chguy.
* Fix account management link for delegated auth OIDC setups ([#12144](matrix-org/matrix-react-sdk#12144)). Contributed by @t3chguy.
* Fix Safari IME support ([#11016](matrix-org/matrix-react-sdk#11016)). Contributed by @SuperKenVery.
* Fix Stickerpicker layout crossing multiple CSS stacking contexts ([#12127](matrix-org/matrix-react-sdk#12127)).
* Fix Stickerpicker layout crossing multiple CSS stacking contexts ([#12126](matrix-org/matrix-react-sdk#12126)). Contributed by @t3chguy.
* Fix 1F97A and 1F979 in Twemoji COLR font ([#12177](matrix-org/matrix-react-sdk#12177)).
## ✨ Features

* Expose apps/widgets ([#12071](matrix-org/matrix-react-sdk#12071)). Contributed by @charlynguyen.
* Enable the rust-crypto labs button ([#12114](matrix-org/matrix-react-sdk#12114)). Contributed by @richvdh.
* Show a progress bar while migrating from legacy crypto ([#12104](matrix-org/matrix-react-sdk#12104)). Contributed by @richvdh.
* Update Twemoji to Jdecked v15.0.3 ([#12147](matrix-org/matrix-react-sdk#12147)). Contributed by @t3chguy.
* Change Quick Settings icon ([#12141](matrix-org/matrix-react-sdk#12141)). Contributed by @florianduros.
* Use Compound tooltips more widely ([#12128](matrix-org/matrix-react-sdk#12128)). Contributed by @t3chguy.

## 🐛 Bug Fixes

* Fix OIDC bugs due to amnesiac stores forgetting OIDC issuer \& other data ([#12166](matrix-org/matrix-react-sdk#12166)). Contributed by @t3chguy.
* Fix account management link for delegated auth OIDC setups ([#12144](matrix-org/matrix-react-sdk#12144)). Contributed by @t3chguy.
* Fix Safari IME support ([#11016](matrix-org/matrix-react-sdk#11016)). Contributed by @SuperKenVery.
* Fix Stickerpicker layout crossing multiple CSS stacking contexts ([#12127](matrix-org/matrix-react-sdk#12127)).
* Fix Stickerpicker layout crossing multiple CSS stacking contexts ([#12126](matrix-org/matrix-react-sdk#12126)). Contributed by @t3chguy.
* Fix 1F97A and 1F979 in Twemoji COLR font ([#12177](matrix-org/matrix-react-sdk#12177)).
## ✨ Features

* Use jitsi-lobby in video channel (video rooms) ([#26879](element-hq/element-web#26879)). Contributed by @toger5.
spantaleev added a commit to spantaleev/matrix-docker-ansible-deploy that referenced this pull request Feb 27, 2024
Ref:
- matrix-org/matrix-react-sdk#12153
- element-hq/element-web#26885

Technically, it may still work for Schildichat, because it's stuck in
the past. It will catch up soon anyway.
KarolosLykos pushed a commit to KarolosLykos/matrix-docker-ansible-deploy that referenced this pull request Mar 5, 2024
Ref:
- matrix-org/matrix-react-sdk#12153
- element-hq/element-web#26885

Technically, it may still work for Schildichat, because it's stuck in
the past. It will catch up soon anyway.
ignyx pushed a commit to Tawkie/matrix-docker-ansible-deploy that referenced this pull request Jun 20, 2024
Ref:
- matrix-org/matrix-react-sdk#12153
- element-hq/element-web#26885

Technically, it may still work for Schildichat, because it's stuck in
the past. It will catch up soon anyway.
Chasethechicken pushed a commit to Chasethechicken/matrix-docker-ansible-deploy that referenced this pull request Jul 6, 2024
Ref:
- matrix-org/matrix-react-sdk#12153
- element-hq/element-web#26885

Technically, it may still work for Schildichat, because it's stuck in
the past. It will catch up soon anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Deprecation A pull request that makes something deprecated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants