Replace Matrix.getKeyBackupEnabled by MatrixClient.CryptoApi.getActiveSessionBackupVersion
#28225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/remove-keybackup-enabled
branch
2 times, most recently
from
3c83dde to
2030b68
Compare
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/remove-keybackup-enabled
branch
from
2030b68 to
a02d1f2
Compare
andybalaam
approved these changes
Oct 18, 2024
… `MatrixClient.CryptoApi.getActiveSessionBackupVersion` in `NewRecoveryMethodDialog`. Rewrite `NewRecoveryMethodDialog` into a functional component to make it easier to handle the new async method.
… `MatrixClient.CryptoApi.getActiveSessionBackupVersion` in `MatrixChat`.
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/remove-keybackup-enabled
branch
from
a02d1f2 to
2d95a09
Compare
florianduros
deleted the
florianduros/rip-out-legacy-crypto/remove-keybackup-enabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Task #26922
Matrix.getKeyBackupEnabledis synchronous andMatrixClient.CryptoApi.getActiveSessionBackupVersionsi asynchronous. The component is fairly trivial and it was a good opportunity to migrate it to a functional component to handle easily the asynchronous.newVersionInfoprops wasn't used in the component so I removed it.