Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace MatrixClient.isRoomEncrypted by MatrixClient.CryptoApi.isEncryptionEnabledInRoom in RoomView #28278

Merged
merged 7 commits into from
Nov 26, 2024
Merged

Replace MatrixClient.isRoomEncrypted by MatrixClient.CryptoApi.isEncryptionEnabledInRoom in RoomView #28278

merged 7 commits into from
Nov 26, 2024

Conversation

florianduros
Copy link
Member

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@florianduros florianduros added the T-Task Tasks for the team like planning label Oct 23, 2024
@florianduros florianduros mentioned this pull request Oct 23, 2024
Open
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/migrate-roomview-isencrypted branch from 14f5088 to 11ddcc1 Compare October 23, 2024 13:47
@florianduros florianduros mentioned this pull request Nov 21, 2024
Merged
4 tasks
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/migrate-roomview-isencrypted branch from 3e64ea0 to a61968f Compare November 22, 2024 09:01
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/migrate-roomview-isencrypted branch 2 times, most recently from 98b0590 to 5217283 Compare November 22, 2024 09:33
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/migrate-roomview-isencrypted branch 2 times, most recently from f965ce1 to 8b42571 Compare November 22, 2024 14:11
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/migrate-roomview-isencrypted branch from 8b42571 to cce60d4 Compare November 22, 2024 15:16
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/migrate-roomview-isencrypted branch from cce60d4 to a9c42bb Compare November 22, 2024 15:42
@florianduros florianduros marked this pull request as ready for review November 22, 2024 16:16
@florianduros florianduros requested a review from a team as a code owner November 22, 2024 16:16
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/migrate-roomview-isencrypted branch 2 times, most recently from b1b653f to 476734f Compare November 25, 2024 15:18
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/migrate-roomview-isencrypted branch from a420a48 to 5ce1e47 Compare November 25, 2024 16:09
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/migrate-roomview-isencrypted branch from 640292b to 8d01c23 Compare November 26, 2024 15:25
@florianduros florianduros requested a review from t3chguy November 26, 2024 15:48
t3chguy
t3chguy requested changes Nov 26, 2024
View reviewed changes
playwright/e2e/crypto/decryption-failure-messages.spec.ts Outdated
@@ -67,6 +67,9 @@ test.describe("Cryptography", function () {
await page.locator(".mx_AuthPage").getByRole("button", { name: "I'll verify later" }).click();
await app.viewRoomByName("Test room");

// In this case, the call to cryptoApi.isEncryptionEnabledInRoom is taking a long time to resolve
await page.waitForTimeout(4000);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 seconds? That seems terrifying, given how few rooms this client is in this sounds like a blocker to using the new API? 4 seconds to open a room is awful?

Copy link
Member Author

@florianduros florianduros Nov 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To open a room in a regular case, it's not taking 4 seconds. I tested manually and the other tests are running fine.

This test is going through already multiple issues (waiting 10sec for keys to be backed up) and I assume this is a special case

@florianduros florianduros mentioned this pull request Nov 26, 2024
Open
@florianduros florianduros added this pull request to the merge queue Nov 26, 2024
Merged via the queue into develop with commit af846f8 Nov 26, 2024
32 checks passed
@florianduros florianduros deleted the florianduros/rip-out-legacy-crypto/migrate-roomview-isencrypted branch November 26, 2024 21:50
@florianduros florianduros mentioned this pull request Nov 27, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @t3chguy