Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new CrytoApi.restoreKeyBackup & CrytoApi.restoreKeyBackupFromPassphrase api #28385

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Use new CrytoApi.restoreKeyBackup & CrytoApi.restoreKeyBackupFromPassphrase api #28385

merged 5 commits into from
Nov 13, 2024

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented Nov 5, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Task #26922
Require matrix-org/matrix-js-sdk#4476
Use CryptoApi.restoreKeyBackup instead of deprecated MatrixClient.restoreKeyBackup*

@florianduros florianduros added the T-Task Tasks for the team like planning label Nov 5, 2024
@florianduros florianduros mentioned this pull request Nov 5, 2024
Open
@florianduros florianduros changed the title Use new CrytoApi.restoreKeyBackup & CrytoApi.restoreKeyBackupFromPassprhase api Use new CrytoApi.restoreKeyBackup & CrytoApi.restoreKeyBackupFromPassphrase api Nov 6, 2024
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/restorekeybackup branch from d67ca3c to 36c92ee Compare November 7, 2024 16:48
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/restorekeybackup branch 2 times, most recently from cecba18 to 0a0ba2a Compare November 8, 2024 16:17
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/restorekeybackup branch from 0a0ba2a to d7abb9f Compare November 8, 2024 16:25
@florianduros florianduros marked this pull request as ready for review November 13, 2024 09:18
@florianduros florianduros requested review from a team as code owners November 13, 2024 09:18
andybalaam
andybalaam approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@florianduros florianduros added this pull request to the merge queue Nov 13, 2024
Merged via the queue into develop with commit c67e67a Nov 13, 2024
40 checks passed
@florianduros florianduros deleted the florianduros/rip-out-legacy-crypto/restorekeybackup branch November 13, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybalaam andybalaam andybalaam approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @andybalaam