Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable react-compiler eslint to spot antipatterns #28652

Draft
wants to merge 12 commits into
base: develop
Choose a base branch
from
Draft

Enable react-compiler eslint to spot antipatterns #28652

wants to merge 12 commits into from

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Dec 5, 2024 •
edited
Loading

Requires #28651

@t3chguy
Switch to React18 useId
b61a222 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Enable react-compiler eslint
c8c5ef5 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Fix an easy one
e730074 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Disable in tests
eb1a09a 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Merge branch 't3chguy/useId' of https://github.com/vector-im/element-web
6c2334c 
 into t3chguy/react-compiler-eslint
@t3chguy
Fix usage of useRef as memoization
9443426 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Fix mutation of external values in hooks
b597abf 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Make React compiler happy about some frankly non-issues
72f1556 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy added the T-Task Tasks for the team like planning label Dec 5, 2024
@t3chguy t3chguy self-assigned this Dec 5, 2024
@t3chguy
Fix MapMock
c3f3c93 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Iterate
6946b90 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Merge branch 'develop' of https://github.com/vector-im/element-web in…
9ef3ea6 
…to t3chguy/react-compiler-eslint

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

# Conflicts:
#	yarn.lock
@t3chguy
Iterate
24d4ecf 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@t3chguy t3chguy

Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@t3chguy