Update redeploy script to keep old bundles #2969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... so that people using old versions of the master chunk can still load other webpack chunks.
dbkr
reviewed
Jan 17, 2017
| @@ -179,18 +257,34 @@ def on_receive_jenkins_poke(): | |||
| To this location." | |||
| ) | |||
| ) | |||
| parser.add_argument( | |||
| "--test", dest="tarball_uri", help=( | |||
There was a problem hiding this comment.
Is this arg supposed to be called '--test'?
|
Yes?
…On 17 January 2017 14:20:55 GMT+00:00, David Baker ***@***.***> wrote:
dbkr commented on this pull request.
Otherwise lgtm
> @@ -179,18 +257,34 @@ def on_receive_jenkins_poke():
To this location."
)
)
+ parser.add_argument(
+ "--test", dest="tarball_uri", help=(
Is this arg supposed to be called '--test'?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#2969 (review)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
|
Conclusion: it is just for testing right now, but the code to do this deploying in the production env is still in the pipeline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... so that people using old versions of the master chunk can still load other
webpack chunks.