Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement connection lost bar + resend all #332

Merged
merged 4 commits into from
Nov 9, 2015
Merged

Implement connection lost bar + resend all #332

merged 4 commits into from
Nov 9, 2015

Conversation

kegsay
Copy link
Contributor

@kegsay kegsay commented Nov 5, 2015

This is missing:

  • Exclamation icon
  • Better CSS

Manually tested and it appears to work. Tested:

  • Contextual menu resend
  • Resend all link
  • No connection bar (appear/disappear on /events calls)

Fixes #197.

@kegsay
Add a 'connection lost' bar.
804af34
@kegsay
Add resending bar (and resend all option)
3a8c263 
Factor out resend logic which was in the context menu into a separate
Resend file (it shouldn't be in the skin, but it also isn't really
suitable for a controller given 2 different views invoke it..)
@kegsay kegsay added the feature label Nov 5, 2015
@kegsay kegsay assigned dbkr and ara4n and unassigned dbkr Nov 5, 2015
@ara4n
Copy link
Member

ara4n commented Nov 9, 2015

LGTM. my only concern is that events doesn't seem to repoll to discover when the server returns? it seems to rely on you issuing a typing notification to 'kick' things to realise that we're back in business...

@kegsay
Copy link
Contributor Author

kegsay commented Nov 9, 2015

It does repoll, but it's not aggressively retrying so we don't kill any homeservers. There is a manual kick option in the SDK but the wireframes have nowhere for it.

@kegsay
Copy link
Contributor Author

kegsay commented Nov 9, 2015

From IRL:

  • Typing notification results in something coming down the event stream which then triggers the state machine from DEAD -> ALIVE. The long timeout on /events means that for the 30s that it's polling, it doesn't know that it has made the connection and so keeps it in the DEAD state.
  • This can be fixed by using timeout=0 on pokes when you think you're DEAD.

@kegsay
Copy link
Contributor Author

kegsay commented Nov 9, 2015

This is a JS SDK thing, so merging this.

kegsay added a commit that referenced this pull request Nov 9, 2015
@kegsay
Merge pull request #332 from vector-im/kegan/syncing
c3385d5 
Implement connection lost bar + resend all
@kegsay kegsay merged commit c3385d5 into develop Nov 9, 2015
@kegsay
Copy link
Contributor Author

kegsay commented Nov 9, 2015

matrix-org/matrix-js-sdk@6eb896e7

@t3chguy t3chguy deleted the kegan/syncing branch May 12, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ara4n ara4n

Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show connectivity state and manage resending messages correctly
4 participants
@kegsay @ara4n @jryans @dbkr